linux(4): Deduplicate unimpl/dummy syscall handlers
ClosedPublic
Actions

Authored by cem on Nov 5 2020, 6:44 AM.

Details

Reviewers

trasz
emaste
brooks
manu

Commits

rG540206069cb6: Direct commit:
rS367395: linux(4): Deduplicate unimpl/dummy syscall handlers

Summary

No functional change.

Test Plan

Tinderbox amd64 arm64 i386 passes.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34639
Build 31721: arc lint + arc unit

Event Timeline

cem created this revision.Nov 5 2020, 6:44 AM

Herald added a reviewer: manu. · View Herald TranscriptNov 5 2020, 6:44 AM

Herald added a subscriber: andrew. · View Herald Transcript

Harbormaster completed remote builds in B34639: Diff 79198.Nov 5 2020, 6:44 AM

cem requested review of this revision.Nov 5 2020, 6:44 AM

I like it. Some of the per-architecture DUMMY() should probably get moved to the MI file too - statx for example - but that's better done later on.

This revision is now accepted and ready to land.Nov 5 2020, 11:10 AM

In D27099#604907, @trasz wrote:

I like it. Some of the per-architecture DUMMY() should probably get moved to the MI file too - statx for example - but that's better done later on.

Thanks! Yeah, I wasn't sure to what extent each of the syscalls.master files was accurate, but that can be updated relatively easily after this big change.

Thanks. I didn't check each individual entry but am very happy to see this.

All of the linux 4.X+ entries likely belong in the common file but agreed that can be a subsequent change

sys/arm64/linux/linux_dummy_machdep.c
4	This is probably not correct for arm64 now

Thanks!

sys/arm64/linux/linux_dummy_machdep.c
4	Just keeping the existing copyright header (this is an `svn mv` from `linux_dummy.c`) for now: https://github.com/freebsd/freebsd/blob/master/sys/arm64/linux/linux_dummy.c#L4

emaste added inline comments.Nov 5 2020, 6:44 PM

sys/arm64/linux/linux_dummy_machdep.c
4	Right - I copied that statement when I copied amd64's dummy file to arm64, but everything that was copied has now been moved to the common file, so all that's left here now is what I added and your comment, which is probably the most copyrightable piece :) Anyway doesn't really matter.