Differential D26971

Switch the arm64 pcpu to a global register variable
ClosedPublic
Actions

Authored by andrew on Oct 27 2020, 2:54 PM.

Tags

None

Referenced Files

	F151556623: D26971.id82216.diff
	Thu, Apr 9, 4:28 AM

	Unknown Object (File)
	Sun, Apr 5, 11:06 AM

	Unknown Object (File)
	Sat, Apr 4, 12:10 AM

	Unknown Object (File)
	Fri, Apr 3, 3:25 AM

	Unknown Object (File)
	Thu, Apr 2, 9:56 PM

	Unknown Object (File)
	Fri, Mar 27, 9:59 AM

	Unknown Object (File)
	Tue, Mar 24, 8:24 PM

	Unknown Object (File)
	Fri, Mar 13, 4:50 AM

Subscribers

Details

Reviewers

manu
emaste

Group Reviewers

Commits

rG63c858a04d56: Switch the arm64 pcpu to a global register variable

Summary

This removes an unneeded instruction to move the pointer from x18 to a
temporary register.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34414
Build 31518: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 27 2020, 2:54 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 27 2020, 2:54 PM

Herald added a subscriber: emaste. · View Herald Transcript

andrew requested review of this revision.Oct 27 2020, 2:54 PM

Harbormaster completed remote builds in B34414: Diff 78812.Oct 27 2020, 2:54 PM

Looks fine to me

GCC ref: https://gcc.gnu.org/onlinedocs/gcc/Global-Register-Variables.html#Global-Register-Variables
Some recentish LLVM discussion on general named global register variables: https://lists.llvm.org/pipermail/llvm-dev/2018-December/128706.html
Related patch: https://reviews.llvm.org/D68862

This revision is now accepted and ready to land.Jan 8 2021, 5:09 PM

Closed by commit rG63c858a04d56: Switch the arm64 pcpu to a global register variable (authored by andrew). · Explain WhyJan 13 2021, 4:43 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG63c858a04d56: Switch the arm64 pcpu to a global register variable.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

include/

17 lines

Diff 78812

sys/arm64/include/pcpu.h

Loading...