arc lint is helpful
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19 Build 19: arc lint + arc unit
Event Timeline
I didn't go all the way through, but if you're going to go through and touch a bunch of comments like this, might as well fix the other issues in those comments. A couple examples at the beginning are noted to give you an idea.
sbin/ipfw/tables.c | ||
---|---|---|
455 | End sentence with a full stop. | |
926 | Start with majuscule letter; end with full stop. | |
1395 | Start with capital 'W'. |
@bjk all these fixes were automated. I did not manually look at the comments beyond verifying that the patch seemed correct.
My 5 cents :)
sbin/newfs_nandfs/newfs_nandfs.c | ||
---|---|---|
1091 | printf("filesystem was created successfully\n"); | |
sbin/rcorder/rcorder.c | ||
223 | from the filename's given dependencies and provisions | |
usr.bin/colldef/parse.y | ||
147 | IO error writing substitution table to destination file %s ? | |
usr.bin/sed/compile.c | ||
367 |
| |
usr.bin/vgrind/regexp.c | ||
321 | The following routines recognises an irregular expression |
This appears to be from running igor -s against a bunch of files. Why these files, exactly?
usr.bin/colldef/parse.y | ||
---|---|---|
147 | "IO" should be "I/O". But the rest of these would need to be fixed also. |
It was actually arc lint --lintall against bin sbin usr.bin and usr.sbin. This automatically produces patches for one to review. Why only these? I got tired :\