Page MenuHomeFreeBSD
Differential D26388

Get rid of sv_errtbl and SV_ABI_ERRNO()
ClosedPublic
Actions

Authored by trasz on Sep 10 2020, 10:35 AM.
Tags
None
Referenced Files
F166278512: D26388.id77063.diff
Wed, Aug 12, 4:20 PM
F166277221: D26388.id77058.diff
Wed, Aug 12, 4:12 PM
F166131394: D26388.diff
Tue, Aug 11, 10:58 PM
Unknown Object (File)
Tue, Aug 11, 7:00 PM
Unknown Object (File)
Tue, Aug 11, 6:06 PM
Unknown Object (File)
Mon, Aug 10, 5:49 AM
Unknown Object (File)
Mon, Aug 10, 5:42 AM
Unknown Object (File)
Sun, Aug 9, 4:52 PM
View All Files
Subscribers
andrew
arichardson
emaste
imp
jhibbits

Details

Reviewers
manu
kib
Commits
rS365832: Get rid of sv_errtbl and SV_ABI_ERRNO().
Summary

Get rid of sv_errtbl and SV_ABI_ERRNO(). This builds
on https://reviews.freebsd.org/D26378.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33576
Build 30828: arc lint + arc unit

Event Timeline

trasz created this revision.Sep 10 2020, 10:35 AM
Herald added a reviewer: manu. · View Herald TranscriptSep 10 2020, 10:35 AM
Herald added subscribers: jhibbits, emaste, andrew, imp. · View Herald Transcript
trasz requested review of this revision.Sep 10 2020, 10:35 AM
Harbormaster completed remote builds in B33481: Diff 76871.Sep 10 2020, 10:35 AM
trasz mentioned this in D26378: Move SV_ABI_ERRNO translation to linux-specific code.Sep 11 2020, 10:33 AM
trasz added a reviewer: kib.Sep 11 2020, 6:26 PM
trasz updated this revision to Diff 77058.Sep 15 2020, 4:45 PM

Regen.

Harbormaster completed remote builds in B33571: Diff 77058.Sep 15 2020, 4:46 PM
kib added inline comments.Sep 15 2020, 5:33 PM
sys/compat/linux/linux_errno.c
23

This is ERESTART. I do not think it is reasonable return.

sys/sys/sysent.h
162

.. even if old code did that.

trasz updated this revision to Diff 77063.Sep 15 2020, 6:37 PM

Be more strict on allowed values and don't return -1 (which would be ERESTART).

Harbormaster completed remote builds in B33576: Diff 77063.Sep 15 2020, 6:37 PM
trasz marked 2 inline comments as done.Sep 15 2020, 6:46 PM
trasz added a comment.Sep 16 2020, 8:59 AM

(Tinderboxed.)

kib accepted this revision.Sep 16 2020, 3:51 PM
This revision is now accepted and ready to land.Sep 16 2020, 3:51 PM
Closed by commit rS365832: Get rid of sv_errtbl and SV_ABI_ERRNO(). (authored by trasz). · Explain WhySep 17 2020, 11:40 AM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS365832: Get rid of sv_errtbl and SV_ABI_ERRNO()..
arichardson added a subscriber: arichardson.Sep 17 2020, 12:54 PM
arichardson added inline comments.
head/sys/compat/linux/linux_errno.c
14 ↗(On Diff #77126)

Isn't this name the wrong way around and should be linux_from_bsd_errno(int error) or freebsd_to_linux_errno?

trasz marked an inline comment as done.Oct 27 2020, 12:50 PM
trasz added inline comments.
head/sys/compat/linux/linux_errno.c
14 ↗(On Diff #77126)

Indeed - fixed in r367079.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
4 lines
linux/
4 lines
linux32/
4 lines
arm/
arm/
2 lines
arm64/
arm64/
2 lines
2 lines
linux/
4 lines
compat/
ia32/
2 lines
linux/
2 lines
15 lines
2 lines
i386/
i386/
2 lines
linux/
6 lines
kern/
4 lines
2 lines
mips/
mips/
2 lines
2 lines
powerpc/
powerpc/
2 lines
4 lines
riscv/
riscv/
2 lines
sys/
4 lines

Diff 77063

View Options

sys/amd64/amd64/elf_machdep.c

Loading...
View Options

sys/amd64/linux/linux_sysvec.c

Loading...
View Options

sys/amd64/linux32/linux32_sysvec.c

Loading...
View Options

sys/arm/arm/elf_machdep.c

Loading...
View Options

sys/arm64/arm64/elf32_machdep.c

Loading...
View Options

sys/arm64/arm64/elf_machdep.c

Loading...
View Options

sys/arm64/linux/linux_sysvec.c

Loading...
View Options

sys/compat/ia32/ia32_sysvec.c

Loading...
View Options

sys/compat/linux/linux.h

Loading...
View Options

sys/compat/linux/linux_errno.c

Loading...
View Options

sys/compat/linux/linux_socket.c

Loading...
View Options

sys/i386/i386/elf_machdep.c

Loading...
View Options

sys/i386/linux/linux_sysvec.c

Loading...
View Options

sys/kern/imgact_aout.c

Loading...
View Options

sys/kern/init_main.c

Loading...
View Options

sys/mips/mips/elf_machdep.c

Loading...
View Options

sys/mips/mips/freebsd32_machdep.c

Loading...
View Options

sys/powerpc/powerpc/elf32_machdep.c

Loading...
View Options

sys/powerpc/powerpc/elf64_machdep.c

Loading...
View Options

sys/riscv/riscv/elf_machdep.c

Loading...
View Options

sys/sys/sysent.h

Loading...