Differential D26418

bridge: Call member interface ioctl() without NET_EPOCH
ClosedPublic
Actions

Authored by kp on Sep 12 2020, 10:06 PM.

Details

Reviewers

glebius

Group Reviewers

network

Commits

rS366500: bridge: call member interface ioctl() without NET_EPOCH

Summary

We're not allowed to hold NET_EPOCH while sleeping, so when we call
ioctl() handlers for member interfaces we cannot be in NET_EPOCH.
We still need some protection of our CK_LISTs, so hold BRIDGE_LOCK
instead.
That requires changing BRIDGE_LOCK into a sleepable lock, and separating
the BRIDGE_RT_LOCK, to protect bridge_rtnode lists. That lock is taken
in the data path (while in NET_EPOCH), so it cannot be a sleepable lock.

While here document the locking stategy.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33532
Build 30792: arc lint + arc unit

Event Timeline

kp created this revision.Sep 12 2020, 10:06 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptSep 12 2020, 10:06 PM

kp requested review of this revision.Sep 12 2020, 10:06 PM

Harbormaster completed remote builds in B33532: Diff 76959.Sep 12 2020, 10:06 PM

emaste added a subscriber: emaste.Sep 13 2020, 1:55 AM

vangyzen added a subscriber: vangyzen.Oct 1 2020, 4:09 PM

bridge: Call member interface ioctl() without NET_EPOCH

While here document the locking stategy.

Harbormaster completed remote builds in B33963: Diff 77815.Oct 3 2020, 3:42 PM

kp retitled this revision from bridge: Do not enter NET_EPOCH in bridge_ioctl() to bridge: Call member interface ioctl() without NET_EPOCH.Oct 3 2020, 3:42 PM

kp edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2020, 7:20 PM

Closed by commit rS366500: bridge: call member interface ioctl() without NET_EPOCH (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rS366500: bridge: call member interface ioctl() without NET_EPOCH.

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2020, 7:20 PM