Page MenuHomeFreeBSD

bridge: Call member interface ioctl() without NET_EPOCH
ClosedPublic

Authored by kp on Sep 12 2020, 10:06 PM.

Details

Summary

We're not allowed to hold NET_EPOCH while sleeping, so when we call
ioctl() handlers for member interfaces we cannot be in NET_EPOCH.
We still need some protection of our CK_LISTs, so hold BRIDGE_LOCK
instead.
That requires changing BRIDGE_LOCK into a sleepable lock, and separating
the BRIDGE_RT_LOCK, to protect bridge_rtnode lists. That lock is taken
in the data path (while in NET_EPOCH), so it cannot be a sleepable lock.

While here document the locking stategy.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 33532
Build 30792: arc lint + arc unit

Event Timeline

kp requested review of this revision.Sep 12 2020, 10:06 PM

bridge: Call member interface ioctl() without NET_EPOCH

We're not allowed to hold NET_EPOCH while sleeping, so when we call
ioctl() handlers for member interfaces we cannot be in NET_EPOCH.
We still need some protection of our CK_LISTs, so hold BRIDGE_LOCK
instead.
That requires changing BRIDGE_LOCK into a sleepable lock, and separating
the BRIDGE_RT_LOCK, to protect bridge_rtnode lists. That lock is taken
in the data path (while in NET_EPOCH), so it cannot be a sleepable lock.

While here document the locking stategy.

kp retitled this revision from bridge: Do not enter NET_EPOCH in bridge_ioctl() to bridge: Call member interface ioctl() without NET_EPOCH.Sat, Oct 3, 3:42 PM
kp edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Oct 6, 7:20 PM
This revision was automatically updated to reflect the committed changes.