[unix(4) cleanup 1/8] Update unix domain socket locking comments.
ClosedPublic
Actions

Authored by markj on Sep 2 2020, 4:55 PM.

Details

Reviewers

glebius
kevans
kib

Commits

rS365759: Update unix domain socket locking comments.

Summary

- Define a locking key for unpcb members.
- Rewrite some of the locking protocol description to make it less
verbose and avoid referencing some subroutines which will be renamed.
- Reorder includes.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33339
Build 30650: arc lint + arc unit

Event Timeline

markj requested review of this revision.Sep 2 2020, 4:55 PM

markj created this revision.

Harbormaster completed remote builds in B33326: Diff 76540.Sep 2 2020, 4:55 PM

markj added a child revision: D26295: [unix(4) cleanup 2/8] Improve unix socket refcounting..Sep 2 2020, 5:08 PM

emaste added a subscriber: emaste.Sep 2 2020, 5:20 PM

kevans added a subscriber: kevans.Sep 2 2020, 6:17 PM

kevans added inline comments.

sys/kern/uipc_usrreq.c
197–201	I think 'local domain socket implementation' was correct here

Typo.

Harbormaster completed remote builds in B33339: Diff 76557.Sep 2 2020, 6:21 PM

emaste added a subscriber: mjg.Sep 2 2020, 8:08 PM

glebius accepted this revision.Sep 3 2020, 4:43 AM

This revision is now accepted and ready to land.Sep 3 2020, 4:43 AM

kevans accepted this revision.Sep 3 2020, 12:59 PM

kib accepted this revision.Sep 10 2020, 11:59 PM

Closed by commit rS365759: Update unix domain socket locking comments. (authored by markj). · Explain WhySep 15 2020, 7:22 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS365759: Update unix domain socket locking comments..

Herald added a subscriber: imp. · View Herald TranscriptSep 15 2020, 7:22 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_usrreq.c

59 lines

sys/

unpcb.h

43 lines

Diff 76557

View Options

sys/kern/uipc_usrreq.c