[unix(4) cleanup 3/8] Rename unp_pcb_lock2().
ClosedPublic
Actions

Authored by markj on Sep 2 2020, 4:55 PM.

Details

Reviewers

kevans
glebius
kib

Commits

rS365761: Rename unp_pcb_lock2().

Summary

I think unp_pcb_lock_pair() is a better name. Also make it handle the
case where the two sockets are the same instead of forcing callers to do
it. No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Sep 2 2020, 4:55 PM

markj created this revision.

Harbormaster completed remote builds in B33328: Diff 76542.Sep 2 2020, 4:56 PM

markj added a parent revision: D26295: [unix(4) cleanup 2/8] Improve unix socket refcounting..Sep 2 2020, 5:08 PM

markj added a child revision: D26297: [unix(4) cleanup 4/8] Simplify unp_disconnect() callers..

emaste added a subscriber: emaste.Sep 2 2020, 5:20 PM

kevans added a subscriber: kevans.Sep 2 2020, 5:24 PM

kevans added inline comments.

sys/kern/uipc_usrreq.c
745 ↗	(On Diff #76542)	Might not be a bad idea to (perhaps later) introduce a unp_pcb_unlock_pair for these cases, if for nothing but the symmetry of lock_pair/unlock_pair to make it easier to verify correctness.