Page MenuHomeFreeBSD
Differential D26297

[unix(4) cleanup 4/8] Simplify unp_disconnect() callers.
ClosedPublic
Actions

Authored by markj on Sep 2 2020, 4:56 PM.
Tags
None
Referenced Files
F166659593: D26297.id76668.diff
Sat, Aug 15, 7:33 AM
F166589778: D26297.diff
Fri, Aug 14, 6:46 PM
Unknown Object (File)
Fri, Aug 14, 2:17 AM
Unknown Object (File)
Thu, Aug 13, 8:50 PM
Unknown Object (File)
Thu, Aug 13, 12:13 PM
Unknown Object (File)
Thu, Aug 13, 7:04 AM
Unknown Object (File)
Wed, Aug 12, 10:17 PM
Unknown Object (File)
Tue, Aug 11, 11:53 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
None
Commits
rS365762: Simplify unp_disconnect() callers.
Summary

In all cases, PCBs are unlocked after unp_disconnect() returns. Since
unp_disconnect() may release the last PCB reference, callers may have to
bump the refcount before the call just so that they can release them
again.

Change unp_disconnect() to release PCB locks as well as connection
references. Remove code that bumps and then releases the refcount.
Tighten assertions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Sep 2 2020, 4:56 PM
markj created this revision.
Harbormaster completed remote builds in B33329: Diff 76543.Sep 2 2020, 4:56 PM
markj added a parent revision: D26296: [unix(4) cleanup 3/8] Rename unp_pcb_lock2()..Sep 2 2020, 5:08 PM
markj added a child revision: D26298: [unix(4) cleanup 5/8] Avoid an unnecessary malloc() for dgram sockets..
emaste added a subscriber: emaste.Sep 2 2020, 5:20 PM
markj updated this revision to Diff 76550.Sep 2 2020, 5:58 PM

Use unp_pcb_unlock_pair().

Harbormaster completed remote builds in B33336: Diff 76550.Sep 2 2020, 5:58 PM
kevans mentioned this in D26295: [unix(4) cleanup 2/8] Improve unix socket refcounting..Sep 3 2020, 5:07 PM
markj added inline comments.Sep 3 2020, 5:46 PM
sys/kern/uipc_usrreq.c
2003 ↗(On Diff #76550)

There is a bug here, fixed later in the series: if unp_conn == NULL we might in fact be dropping the last reference here.

markj updated this revision to Diff 76668.Sep 4 2020, 8:14 PM

Don't use unp_pcb_rele_notlast() when we may in fact be releasing the last ref.

Harbormaster completed remote builds in B33400: Diff 76668.Sep 4 2020, 8:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 15 2020, 7:22 PM
Closed by commit rS365762: Simplify unp_disconnect() callers. (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS365762: Simplify unp_disconnect() callers..
Herald added a subscriber: imp. · View Herald TranscriptSep 15 2020, 7:22 PM

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
82 lines

Diff 77068

View Options

head/sys/kern/uipc_usrreq.c

Loading...