Add a GPIO driver for the Raspberry Pi firmware GPIOs
ClosedPublic
Actions

Authored by andrew on Jul 28 2020, 2:33 PM.

Details

Reviewers

Group Reviewers

ARM
arm64

Commits

rS363802: Add a GPIO driver for the Raspberry Pi firmware GPIOs

Summary

These exist on the Raspberry Pi 3 and 4 and control and external IO
expander.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32726
Build 30169: arc lint + arc unit

Event Timeline

andrew created this revision.Jul 28 2020, 2:33 PM

Herald added a subscriber: emaste. · View Herald TranscriptJul 28 2020, 2:33 PM

andrew requested review of this revision.Jul 28 2020, 2:33 PM

Harbormaster completed remote builds in B32612: Diff 75066.Jul 28 2020, 2:33 PM

manu added a subscriber: manu.Jul 29 2020, 8:20 AM

manu added inline comments.

sys/arm/broadcom/bcm2835/raspberrypi_gpio.c
173	Is all this needed ? Can't you just test that the pin isn't > RPI_FW_GPIO_PINS and if not return DEFAULT_CAPS ?

gbe added a subscriber: gbe.Jul 29 2020, 1:29 PM

Always return RPI_FW_GPIO_DEFAULT_CAPS from getcaps.

Harbormaster completed remote builds in B32726: Diff 75316.Aug 3 2020, 5:10 PM

manu accepted this revision.Aug 3 2020, 5:14 PM

This revision is now accepted and ready to land.Aug 3 2020, 5:14 PM

Closed by commit rS363802: Add a GPIO driver for the Raspberry Pi firmware GPIOs (authored by andrew). · Explain WhyAug 3 2020, 5:18 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rS363802: Add a GPIO driver for the Raspberry Pi firmware GPIOs.

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2020, 5:18 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

broadcom/

bcm2835/

raspberrypi_gpio.c

457 lines

conf/

files.arm64

1 line

Diff 75316

View Options

sys/arm/broadcom/bcm2835/raspberrypi_gpio.c