Paths

Table of Contentst

Differential D25705

freebsd-version(1): Add -j flag to support jails
ClosedPublic
Actions

Authored by kfv_kfv.io on Jul 17 2020, 12:13 PM.

Tags

None

Referenced Files

	F106186156: D25705.id74569.diff
	Thu, Dec 26, 7:53 PM

	F106185071: D25705.id96098.diff
	Thu, Dec 26, 7:26 PM

	F106154673: D25705.diff
	Thu, Dec 26, 7:13 AM

	Unknown Object (File)
	Tue, Dec 3, 5:28 AM

	Unknown Object (File)
	Nov 23 2024, 3:08 PM

	Unknown Object (File)
	Nov 22 2024, 2:39 PM

	Unknown Object (File)
	Nov 14 2024, 10:24 PM

	Unknown Object (File)
	Nov 14 2024, 10:48 AM

View All 85 Files

Subscribers

Details

Reviewers

dteske
kevans

Group Reviewers

manpages
Contributor Reviews (src)

Commits

rGcae3560307ec: freebsd-version(1): Add -j flag to support jails
rG98520e682d0b: freebsd-version(1): Add -j flag to support jails
rGf54b18fc4d72: freebsd-version(1): Add -j flag to support jails

Summary

Make freebsd-version(1) support jails by adding the -j flag which takes jail jid or name as an argument.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32379
Build 29860: arc lint + arc unit

Event Timeline

kfv_kfv.io created this revision.Jul 17 2020, 12:13 PM

Herald added a reviewer: manpages. · View Herald TranscriptJul 17 2020, 12:14 PM

Herald added a subscriber: imp. · View Herald Transcript

kfv_kfv.io requested review of this revision.Jul 17 2020, 12:14 PM

Harbormaster completed remote builds in B32379: Diff 74569.Jul 17 2020, 12:14 PM

OK from manpages. A useful feature, I might add.

kfv_kfv.io added a child revision: D25711: freebsd-update(8): Add -j flag to support jails.Jul 18 2020, 12:24 AM

0mp added a subscriber: 0mp.Aug 4 2020, 8:33 AM

kfv_kfv.io mentioned this in D25711: freebsd-update(8): Add -j flag to support jails.Feb 3 2021, 2:41 PM

kevans added a subscriber: kevans.Feb 25 2021, 4:32 PM

kevans added inline comments.

bin/freebsd-version/freebsd-version.sh.in
120	We should probably warn if $opt_j == 1 already, but as a future addition it'd be neat if we could support manually-driven usage like: freebsd-version -j1 -j2 -j3 to fetch the versions of multiple jails, but I don't think that's important to do up front.

kevans added a reviewer: kevans.Feb 25 2021, 4:33 PM

freebsd-version(1): accept multiple occurrences of the -j option

Harbormaster completed remote builds in B37387: Diff 84715.Feb 25 2021, 9:32 PM

kfv_kfv.io marked an inline comment as done.Feb 25 2021, 9:44 PM

kfv_kfv.io added inline comments.

bin/freebsd-version/freebsd-version.sh.in
120	I just took care of that, but I didn't know if I should eliminate duplicates, so the user can currently do something like: freebsd-version -j1 -j1 -j2 -j1 And in return, we give them the versions in the same order as specified. Please let me know if I should change this behaviour.

@kevans: by the way, on the subject of the attribution we discussed in IRC, I prefer Faraz Vahedi <kfv@kfv.io>, thanks!

kfv_kfv.io added a reviewer: Contributor Reviews (src).Apr 19 2021, 8:18 AM

kfv_kfv.io changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.May 1 2021, 5:45 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2021, 6:51 PM

Closed by commit rGf54b18fc4d72: freebsd-version(1): Add -j flag to support jails (authored by kfv_kfv.io, committed by kevans). · Explain Why

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGf54b18fc4d72: freebsd-version(1): Add -j flag to support jails.

kevans added a commit: rG98520e682d0b: freebsd-version(1): Add -j flag to support jails.Oct 8 2021, 4:28 PM

kevans added a commit: rGcae3560307ec: freebsd-version(1): Add -j flag to support jails.

egypcio mentioned this in D27318: freebsd-version(1): present -v option, to print verbose output.Nov 15 2021, 3:02 PM

Revision Contents
Changeset List

Path

Size

bin/

freebsd-version/

freebsd-version.1

12 lines

freebsd-version.sh.in

23 lines

Diff 74569

bin/freebsd-version/freebsd-version.1

Loading...

bin/freebsd-version/freebsd-version.sh.in

Loading...