Fix KASSERT during tcp_newtcpcb when low on memory
ClosedPublic
Actions

Authored by rscheff on Jul 6 2020, 9:56 PM.

Details

Reviewers

rrs
jtl
tuexen
rgrimes
cc

Group Reviewers

transport

Commits

rS364376: MFC r362988: Fix KASSERT during tcp_newtcpcb when low on memory
rS362988: Fix KASSERT during tcp_newtcpcb when low on memory

Summary

While testing with system default cc set to cubic, and
running a memory exhaustion validation, FreeBSD panics for a
missing inpcb reference / lock.

Test Plan

Modify modular CC, to return ENOMEM during the _cb_init() function;
load modified CC, and temporarily switch to it as default CC.
Validate that a new session fails with "socket: No buffer space available", instead of a kernel panic (kassert).
Unset the modified CC as default algorithm.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Jul 6 2020, 9:56 PM

Herald added a reviewer: transport. · View Herald TranscriptJul 6 2020, 9:56 PM

Herald added a subscriber: melifaro. · View Herald Transcript

rscheff requested review of this revision.Jul 6 2020, 9:56 PM

Harbormaster completed remote builds in B32174: Diff 74144.Jul 6 2020, 9:56 PM

rscheff edited the test plan for this revision. (Show Details)Jul 7 2020, 9:37 AM

rgrimes accepted this revision.Jul 7 2020, 10:50 AM

tuexen accepted this revision.Jul 7 2020, 11:56 AM

This revision is now accepted and ready to land.Jul 7 2020, 11:56 AM

Closed by commit rS362988: Fix KASSERT during tcp_newtcpcb when low on memory (authored by rscheff). · Explain WhyJul 7 2020, 12:11 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rS362988: Fix KASSERT during tcp_newtcpcb when low on memory.

Herald added a subscriber: imp. · View Herald TranscriptJul 7 2020, 12:11 PM

rscheff mentioned this in D25903: Leaks of inpcb.Jul 31 2020, 8:23 AM

rscheff added a commit: rS364376: MFC r362988: Fix KASSERT during tcp_newtcpcb when low on memory.Aug 19 2020, 10:32 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_subr.c

12 lines

Diff 74152

View Options

head/sys/netinet/tcp_subr.c

Context not available.
	.PATH: ${SRCTOP}/sys/netpfil/pf	.PATH: ${SRCTOP}/sys/netpfil/pf
	PF= pf.h \	PF= pf.h \
	pf_altq.h \	pf_altq.h \
	pf_mtag.h	pf_mtag.h \
		pf_nl.h
	PFPACKAGE= pf	PFPACKAGE= pf
	PFDIR= ${INCLUDEDIR}/netpfil/pf	PFDIR= ${INCLUDEDIR}/netpfil/pf

Context not available.

Fix KASSERT during tcp_newtcpcb when low on memoryClosedPublicActions