Add basic routing LPM tests.
ClosedPublic
Actions

Authored by melifaro on May 4 2020, 1:13 PM.

Details

Reviewers

None

Group Reviewers

network

Commits

rS360685: Add basic routing LPM tests.

Summary

Add basic longest-prefix match tests for IPv4/IPv6.

Tests performs LPM checks based on the dataplane behaviour.
While it may be easier to use route -n get for some of the tests,
in fact it executes somewhat different codepath (rn_lookup() vs rn_match()).

In the future more tests will be added to cover both control plane
and dataplane lookups.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30893
Build 28608: arc lint + arc unit

Event Timeline

melifaro created this revision.May 4 2020, 1:13 PM

Herald added subscribers: bz, ae, asomers, imp. · View Herald TranscriptMay 4 2020, 1:13 PM

melifaro requested review of this revision.May 4 2020, 1:13 PM

Harbormaster completed remote builds in B30893: Diff 71357.May 4 2020, 1:13 PM

There are some non-rfc1918 IPs used in these cases. Are they necessary?

In D24684#543497, @lwhsu wrote:

There are some non-rfc1918 IPs used in these cases. Are they necessary?

They're TEST-NET-2/3 documentation prefixes, so I think they're fine. Probably even better than RFC1918 private ranges.
I tend to use TEST-NET-1 in the pf tests.

In D24684#543497, @lwhsu wrote:

There are some non-rfc1918 IPs used in these cases. Are they necessary?

Well, all these blocks are documentation prefixes from RFC5737.
Technically it can be converted to RFC1918 blocks, but I'm not sure what's the benefit.

Could you please clarify your concerns?

In D24684#543504, @melifaro wrote:

Could you please clarify your concerns?

Thanks for the information and no other concerns. I thought they were public IPs and got confused. Sorry for the noise.

In D24684#543517, @lwhsu wrote:

In D24684#543504, @melifaro wrote:

Could you please clarify your concerns?

Thanks for the information and no other concerns. I thought they were public IPs and got confused. Sorry for the noise.

Np!
In fact, I use TEST-NET-3 pretty rarely so after looking into that revision (it was sitting locally for quite a while) I suspected that I indeed used public IP range :-)

This revision was not accepted when it landed; it landed in state Needs Review.May 6 2020, 7:48 AM

Closed by commit rS360685: Add basic routing LPM tests. (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS360685: Add basic routing LPM tests..