Retire the CRYPTO_F_IV_GENERATE flag.
ClosedPublic
Actions

Authored by jhb on Apr 16 2020, 9:11 PM.

Details

Reviewers

cem
jmg

Group Reviewers

manpages

Commits

rS360136: Retire the CRYPTO_F_IV_GENERATE flag.

Summary

Add a helper routine for drivers to read the current request's IV out
into a buffer and use it to replace code duplicated in nearly all
drivers to read the current IV.

Test Plan

make tinderbox, cryptocheck, IPsec tunnel

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 16 2020, 9:11 PM

Herald added subscribers: ae, andrew. · View Herald TranscriptApr 16 2020, 9:11 PM

Harbormaster completed remote builds in B30541: Diff 70658.Apr 16 2020, 9:11 PM

jhb added a parent revision: D24449: Generate IVs directly in esp output..Apr 16 2020, 9:11 PM

Great!

sys/opencrypto/crypto.c
1363–1364 ↗	(On Diff #70658)	✔️

This revision is now accepted and ready to land.Apr 16 2020, 9:47 PM

Closed by commit rS360136: Retire the CRYPTO_F_IV_GENERATE flag. (authored by jhb). · Explain WhyApr 20 2020, 10:25 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS360136: Retire the CRYPTO_F_IV_GENERATE flag..

Herald added a reviewer: jmg. · View Herald TranscriptApr 20 2020, 10:25 PM

Herald added a reviewer: manpages. · View Herald Transcript

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

share/

man/

man9/

Makefile

1 line

crypto_driver.9

10 lines

crypto_request.9

12 lines

sys/

crypto/

aesni/

aesni.c

9 lines

armv8/

armv8_crypto.c

9 lines

ccp/

ccp_hardware.c

8 lines

via/

padlock_cipher.c

8 lines

dev/

cesa/

cesa.c

13 lines

cxgbe/

crypto/

t4_crypto.c

28 lines

glxsb/

glxsb.c

8 lines

hifn/

hifn7751.c

16 lines

safe/

safe.c

11 lines

sec/

sec.c

14 lines

ubsec/

ubsec.c

10 lines

mips/

cavium/

cryptocteon/

cryptocteon.c

7 lines

nlm/

dev/

sec/

nlmsec.c

6 lines

opencrypto/

crypto.c

15 lines

cryptodev.h

13 lines

cryptosoft.c

25 lines

Diff 70822

View Options

head/share/man/man9/Makefile

View Options

head/share/man/man9/crypto_driver.9

View Options

head/share/man/man9/crypto_request.9

View Options

head/sys/crypto/aesni/aesni.c

View Options

head/sys/crypto/armv8/armv8_crypto.c

View Options

head/sys/crypto/ccp/ccp_hardware.c

View Options

head/sys/crypto/via/padlock_cipher.c

View Options

head/sys/dev/cesa/cesa.c

View Options

head/sys/dev/cxgbe/crypto/t4_crypto.c

View Options

head/sys/dev/glxsb/glxsb.c

View Options

head/sys/dev/hifn/hifn7751.c

View Options

head/sys/dev/safe/safe.c

View Options

head/sys/dev/sec/sec.c

View Options

head/sys/dev/ubsec/ubsec.c

View Options

head/sys/mips/cavium/cryptocteon/cryptocteon.c

View Options

head/sys/mips/nlm/dev/sec/nlmsec.c

View Options

head/sys/opencrypto/crypto.c

View Options

head/sys/opencrypto/cryptodev.h

View Options

head/sys/opencrypto/cryptosoft.c

Retire the CRYPTO_F_IV_GENERATE flag.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 70822

head/share/man/man9/Makefile

head/share/man/man9/crypto_driver.9

head/share/man/man9/crypto_request.9

head/sys/crypto/aesni/aesni.c

head/sys/crypto/armv8/armv8_crypto.c

head/sys/crypto/ccp/ccp_hardware.c

head/sys/crypto/via/padlock_cipher.c

head/sys/dev/cesa/cesa.c

head/sys/dev/cxgbe/crypto/t4_crypto.c

head/sys/dev/glxsb/glxsb.c

head/sys/dev/hifn/hifn7751.c

head/sys/dev/safe/safe.c

head/sys/dev/sec/sec.c

head/sys/dev/ubsec/ubsec.c

head/sys/mips/cavium/cryptocteon/cryptocteon.c

head/sys/mips/nlm/dev/sec/nlmsec.c

head/sys/opencrypto/crypto.c

head/sys/opencrypto/cryptodev.h

head/sys/opencrypto/cryptosoft.c

Retire the CRYPTO_F_IV_GENERATE flag.
ClosedPublic
Actions

Revision Contents
Changeset List