ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6"
ClosedPublic
Actions

Authored by nc on Apr 13 2020, 9:23 PM.

Details

Reviewers

melifaro
ae
rgrimes
donner

Commits

rS362582: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6".

Summary

ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6". This prevents unneeded code duplication.

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

nc created this revision.Apr 13 2020, 9:23 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 13 2020, 9:23 PM

Space out the comment ending.

donner accepted this revision.Apr 14 2020, 7:25 AM

This revision is now accepted and ready to land.Apr 14 2020, 7:25 AM

rgrimes accepted this revision.Apr 14 2020, 3:25 PM

nc mentioned this in D24021: ipfw: Add me4 as to refer to an host's IPv4 address in add_src() and add_dst()..May 12 2020, 3:33 AM

I'm not a committer (I'm also not neel@), could someone please commit this?

nc added a project: transport.Jun 23 2020, 8:46 PM

nc added a subscriber: transport.

nc abandoned this revision.Jun 24 2020, 2:26 PM

nc reclaimed this revision.Jun 24 2020, 3:02 PM

This revision is now accepted and ready to land.Jun 24 2020, 3:02 PM

Closed by commit rS362582: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6". (authored by markj). · Explain WhyJun 24 2020, 3:05 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS362582: ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6"..

Revision Contents
Changeset List

Path

Size

sbin/

ipfw/

ipv6.c

9 lines

Diff 70521

View Options

ipfw(8): In fill_ip6(), use a single statement for both "me" and "me6"ClosedPublicActions