Add basic tests verifying most common output codepaths for TCP,UDP and raw sockets.
Each test is implemented in 2 vnet jails, interacting over epair interface(s).
Multipath tests currently do not work on stock -head.
Details
Details
- Reviewers
kp bz - Group Reviewers
network transport - Commits
- rS359235: Add tests verifying IPv4/IPv6 output for TCP/UDP/raw paths.
kyua test -k /usr/tests/sys/netinet/Kyuafile output output:output_raw_flowid_mpath_success -> passed [0.462s] output:output_raw_success -> passed [0.083s] output:output_tcp_flowid_mpath_success -> passed [1.889s] output:output_tcp_setup_success -> passed [0.171s] output:output_udp_flowid_mpath_success -> passed [9.382s] output:output_udp_setup_success -> passed [1.265s]
kyua test -k /usr/tests/sys/netinet6/Kyuafile output6 output6:output6_raw_flowid_mpath_success -> passed [2.224s] output6:output6_raw_success -> passed [1.904s] output6:output6_tcp_flowid_mpath_success -> passed [2.817s] output6:output6_tcp_setup_success -> passed [1.753s] output6:output6_udp_flowid_mpath_success -> passed [5.127s] output6:output6_udp_setup_success -> passed [3.138s]
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| tests/sys/common/vnet.subr | ||
|---|---|---|
| 16 ↗ | (On Diff #69719) | Do we need this? We should already be adding epair0a to created_interfaces.lst, and deleting that one deletes epair0b as well. |
| tests/sys/common/vnet.subr | ||
|---|---|---|
| 16 ↗ | (On Diff #69719) | In short, yes. Currently, there is no guarantee that jail is destroyed upon return of the jail -r cmd. For example, when some connections inside the jail are in TIME_WAIT state, destruction is delayed till fin_wait2 timeout. As a result, interface may appear in the host jail only after 60 seconds. Please take a look at the following example: #!/bin/sh epair=$(ifconfig epair create) jail_name=j-`date +%s` jail -c name=${jail_name}a persist vnet vnet.interface=${epair} jail -c name=${jail_name}b persist vnet vnet.interface=${epair%a}b jexec ${jail_name}a ifconfig ${epair} inet 192.168.0.1/24 jexec ${jail_name}b ifconfig ${epair%a}b inet 192.168.0.2/24 jexec ${jail_name}b nc -l 4242 & sleep 0.1 echo test | jexec ${jail_name}a nc -Nn 192.168.0.2 4242 jexec ${jail_name}a netstat -an jail -r ${jail_name}a jail -r ${jail_name}b sleep 0.1 ifconfig -l echo ---- jls -N echo ---- jls -dN echo Sleeping.. sleep 58 ifconfig -l sleep 3 ifconfig -l It outputs test Active Internet connections (including servers) Proto Recv-Q Send-Q Local Address Foreign Address (state) tcp4 0 0 192.168.0.1.48519 192.168.0.2.4242 TIME_WAIT em0 em1 em2 lo0 epair0b ---- JID IP Address Hostname Path ---- JID IP Address Hostname Path j-1584786208a / Sleeping.. em0 em1 em2 lo0 epair0b em0 em1 em2 lo0 epair0b epair0a |
Comment Actions
@bz could you consider taking a look?
| tests/sys/common/vnet.subr | ||
|---|---|---|
| 16 ↗ | (On Diff #69719) | Let me put it differently: it does not guarantee that interface won't be leaked but increases this possibility. I'd prefer to have the proper solution but was unable to find one.
|