Differential D23837

Retire procfs-based process debugging.
ClosedPublic
Actions

Authored by jhb on Feb 25 2020, 5:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 9:45 PM

	Unknown Object (File)
	Mon, Nov 18, 1:04 PM

	Unknown Object (File)
	Tue, Nov 5, 4:01 AM

	Unknown Object (File)
	Oct 19 2024, 12:29 AM

	Unknown Object (File)
	Oct 16 2024, 12:08 PM

	Unknown Object (File)
	Oct 2 2024, 5:44 PM

	Unknown Object (File)
	Oct 1 2024, 12:40 PM

	Unknown Object (File)
	Sep 29 2024, 11:06 PM

View All 93 Files

Subscribers

Details

Reviewers

manu
kib
mjg

Commits

rS359530: Retire procfs-based process debugging.

Summary

Modern debuggers and process tracers use ptrace() rather than procfs
for debugging. ptrace() has a supserset of functionality available
via procfs and new debugging features are only added to ptrace().
While the two debugging services share some fields in struct proc,
they each use dedicated fields and separate code. This results in
extra complexity to support a feature that hasn't been enabled in the
default install for several years.

Test Plan

passes make tinderbox and ptrace_test tests

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29610
Build 27471: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 25 2020, 5:51 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 25 2020, 5:52 PM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B29610: Diff 68814.Feb 25 2020, 5:52 PM

jhb added a parent revision: D23822: Mark procfs-based process debugging as deprecated for FreeBSD 13..Feb 25 2020, 5:52 PM

no objection here

Note that there is a parent review to add a deprecation notice that is waiting for an exa-run. I will do a separate exp-run for this one after the first is committed since this removes the header entirely.

mjg accepted this revision.Feb 25 2020, 7:33 PM

mjg mentioned this in D23685: Remove long broken procfs-based process tracing..

This revision is now accepted and ready to land.Feb 25 2020, 7:33 PM

kib accepted this revision.Feb 25 2020, 9:09 PM

kib added inline comments.

sys/amd64/amd64/vm_machdep.c
205	Isn't TDB_STOPATFORK enough, and even better for the same purpose ?

I've rebased the patch set, but need to let a tinderbox build finish. After that I will refresh the review and request an exp-run.

Rebase.
Drop comment about PTRACE_FORK.
Remove #warning workarounds.
Remove pioctl.h.

This revision now requires review to proceed.Mar 20 2020, 10:01 PM

Harbormaster completed remote builds in B30033: Diff 69735.Mar 20 2020, 10:01 PM

exp-run requested at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244939

This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2020, 4:02 AM

Closed by commit rS359530: Retire procfs-based process debugging. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS359530: Retire procfs-based process debugging..

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2020, 4:02 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

1 line

16 lines

ia32/

1 line

1 line

1 line

arm/

arm/

1 line

arm64/

arm64/

1 line

compat/

ia32/

1 line

conf/

1 line

fs/

procfs/

2 lines

5 lines

i386/

i386/

1 line

16 lines

kern/

1 line

7 lines

17 lines

11 lines

3 lines

28 lines

12 lines

7 lines

1 line

24 lines

mips/

mips/

1 line

modules/

procfs/

1 line

powerpc/

powerpc/

1 line

riscv/

riscv/

1 line

sys/

21 lines

Diff 68814

sys/amd64/amd64/trap.c

Loading...

sys/amd64/amd64/vm_machdep.c

Loading...

sys/amd64/ia32/ia32_reg.c

Loading...

sys/amd64/ia32/ia32_signal.c

Loading...

sys/amd64/ia32/ia32_syscall.c

Loading...

sys/arm/arm/syscall.c

Loading...

sys/arm64/arm64/trap.c

Loading...

sys/compat/ia32/ia32_sysvec.c

Loading...

sys/conf/files

Loading...

sys/fs/procfs/procfs.h

Loading...

sys/fs/procfs/procfs.c

Loading...

sys/fs/procfs/procfs_ioctl.c

Loading...

sys/i386/i386/trap.c

Loading...

sys/i386/i386/vm_machdep.c

Loading...

sys/kern/imgact_elf.c

Loading...

sys/kern/kern_exec.c

Loading...

sys/kern/kern_exit.c

Loading...

sys/kern/kern_fork.c

Loading...

sys/kern/kern_prot.c

Loading...

sys/kern/kern_sig.c

Loading...

sys/kern/kern_thread.c

Loading...

sys/kern/subr_syscall.c

Loading...

sys/kern/subr_trap.c

Loading...

sys/kern/sys_process.c

Loading...

sys/mips/mips/trap.c

Loading...

sys/modules/procfs/Makefile

Loading...

sys/powerpc/powerpc/trap.c

Loading...

sys/riscv/riscv/trap.c

Loading...

sys/sys/pioctl.h

Loading...

sys/sys/proc.h

Loading...