Paths

Table of Contentst

-
sys/
-
amd64/
-
amd64/
-
trap.c
-
vm_machdep.c
-
ia32/
-
ia32_reg.c
-
ia32_signal.c
-
ia32_syscall.c
-
arm/arm/
-
arm/
-
syscall.c
-
arm64/arm64/
-
arm64/
-
trap.c
-
compat/ia32/
-
ia32/
-
ia32_sysvec.c
-
conf/
-
files
-
fs/procfs/
-
procfs/
-
procfs.h
-
procfs.c
-
procfs_ioctl.c
-
i386/i386/
-
i386/
-
trap.c
-
vm_machdep.c
-
kern/
-
imgact_elf.c
-
kern_exec.c
-
kern_exit.c
-
kern_fork.c
-
kern_prot.c
-
kern_sig.c
-
kern_thread.c
-
subr_syscall.c
-
subr_trap.c
-
sys_process.c
-
mips/mips/
-
mips/
-
trap.c
-
modules/procfs/
-
procfs/
-
Makefile
-
powerpc/powerpc/
-
powerpc/
-
trap.c
-
riscv/riscv/
-
riscv/
-
trap.c
-
sys/
-
pioctl.h
-
proc.h

Retire procfs-based process debugging.
ClosedPublic
Actions

Authored by jhb on Feb 25 2020, 5:51 PM.

Details

Reviewers

manu
kib
mjg

Commits

rS359530: Retire procfs-based process debugging.

Summary

Modern debuggers and process tracers use ptrace() rather than procfs
for debugging. ptrace() has a supserset of functionality available
via procfs and new debugging features are only added to ptrace().
While the two debugging services share some fields in struct proc,
they each use dedicated fields and separate code. This results in
extra complexity to support a feature that hasn't been enabled in the
default install for several years.

Test Plan

passes make tinderbox and ptrace_test tests

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29610
Build 27471: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 25 2020, 5:51 PM

Herald added a reviewer: manu. · View Herald TranscriptFeb 25 2020, 5:52 PM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B29610: Diff 68814.Feb 25 2020, 5:52 PM

jhb added a parent revision: D23822: Mark procfs-based process debugging as deprecated for FreeBSD 13..Feb 25 2020, 5:52 PM

no objection here

Note that there is a parent review to add a deprecation notice that is waiting for an exa-run. I will do a separate exp-run for this one after the first is committed since this removes the header entirely.

mjg accepted this revision.Feb 25 2020, 7:33 PM

mjg mentioned this in D23685: Remove long broken procfs-based process tracing..

This revision is now accepted and ready to land.Feb 25 2020, 7:33 PM

kib accepted this revision.Feb 25 2020, 9:09 PM

kib added inline comments.

sys/amd64/amd64/vm_machdep.c
205	Isn't TDB_STOPATFORK enough, and even better for the same purpose ?

I've rebased the patch set, but need to let a tinderbox build finish. After that I will refresh the review and request an exp-run.

Rebase.
Drop comment about PTRACE_FORK.
Remove #warning workarounds.
Remove pioctl.h.

This revision now requires review to proceed.Mar 20 2020, 10:01 PM

Harbormaster completed remote builds in B30033: Diff 69735.Mar 20 2020, 10:01 PM

exp-run requested at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244939

This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2020, 4:02 AM

Closed by commit rS359530: Retire procfs-based process debugging. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS359530: Retire procfs-based process debugging..

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2020, 4:02 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

trap.c

1 line

vm_machdep.c

16 lines

ia32/

ia32_reg.c

1 line

ia32_signal.c

1 line

ia32_syscall.c

1 line

arm/

syscall.c

1 line

arm64/

trap.c

1 line

compat/

ia32/

ia32_sysvec.c

1 line

conf/

files

1 line

fs/

procfs/

2 lines

5 lines

i386/

1 line

16 lines

kern/

1 line

7 lines

17 lines

11 lines

3 lines

28 lines

12 lines

7 lines

1 line

24 lines

mips/

trap.c

1 line

modules/

procfs/

Makefile

1 line

powerpc/

trap.c

1 line

riscv/

trap.c

1 line

sys/

pioctl.h

proc.h

21 lines

Diff 68814

View Options

sys/amd64/amd64/trap.c

	Show All 19 Lines
	* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
	* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
	* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
	* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
	*/			*/
	#ifndef _VERIFY_FILE_H_			#ifndef _VERIFY_FILE_H_
	#define _VERIFY_FILE_H_			#define _VERIFY_FILE_H_

				#include <sys/stat.h>
				sjgUnsubmitted Not Done Inline Actions FWIW I just added `struct stat;` but haven't been able to update the review sjg: FWIW I just added `struct stat;` but haven't been able to update the review
				kdAuthorUnsubmitted Not Done Inline Actions Ok, I'll remove it. I supposed that in the end I'll have to rebase on your path after it is merged into the tree. kd: Ok, I'll remove it. I supposed that in the end I'll have to rebase on your path after it is…

	#define VE_GUESS -1 /* let verify_file work it out */			#define VE_GUESS -1 /* let verify_file work it out */
	#define VE_TRY 0 /* we don't mind if unverified */			#define VE_TRY 0 /* we don't mind if unverified */
	#define VE_WANT 1 /* we want this verified */			#define VE_WANT 1 /* we want this verified */
	#define VE_MUST 2 /* this must be verified */			#define VE_MUST 2 /* this must be verified */

	#define VE_VERIFIED 1 /* all good */			#define VE_VERIFIED 1 /* all good */
	#define VE_UNVERIFIED_OK 0 /* not verified but that's ok */			#define VE_UNVERIFIED_OK 0 /* not verified but that's ok */
	#define VE_NOT_VERIFYING 2 /* we are not verifying */			#define VE_NOT_VERIFYING 2 /* we are not verifying */

	void ve_debug_set(int);			void ve_debug_set(int);
	int ve_status_get(int);			int ve_status_get(int);
				void ve_efi_init(void);
				sjgUnsubmitted Not Done Inline Actions can you make sure this is aligned with other prototypes sjg: can you make sure this is aligned with other prototypes
	int load_manifest(const char , const char , const char , struct stat );			int load_manifest(const char , const char , const char , struct stat );
	int verify_file(int, const char *, off_t, int);			int verify_file(int, const char *, off_t, int);
	void verify_pcr_export(void);			void verify_pcr_export(void);

	#endif /* _VERIFY_FILE_H_ */			#endif /* _VERIFY_FILE_H_ */

View Options

sys/amd64/amd64/vm_machdep.c

	Show All 19 Lines
	* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
	* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
	* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
	* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
	*/			*/
	#ifndef _VERIFY_FILE_H_			#ifndef _VERIFY_FILE_H_
	#define _VERIFY_FILE_H_			#define _VERIFY_FILE_H_

				#include <sys/stat.h>
				sjgUnsubmitted Not Done Inline Actions FWIW I just added `struct stat;` but haven't been able to update the review sjg: FWIW I just added `struct stat;` but haven't been able to update the review
				kdAuthorUnsubmitted Not Done Inline Actions Ok, I'll remove it. I supposed that in the end I'll have to rebase on your path after it is merged into the tree. kd: Ok, I'll remove it. I supposed that in the end I'll have to rebase on your path after it is…

	#define VE_GUESS -1 /* let verify_file work it out */			#define VE_GUESS -1 /* let verify_file work it out */
	#define VE_TRY 0 /* we don't mind if unverified */			#define VE_TRY 0 /* we don't mind if unverified */
	#define VE_WANT 1 /* we want this verified */			#define VE_WANT 1 /* we want this verified */
	#define VE_MUST 2 /* this must be verified */			#define VE_MUST 2 /* this must be verified */

	#define VE_VERIFIED 1 /* all good */			#define VE_VERIFIED 1 /* all good */
	#define VE_UNVERIFIED_OK 0 /* not verified but that's ok */			#define VE_UNVERIFIED_OK 0 /* not verified but that's ok */
	#define VE_NOT_VERIFYING 2 /* we are not verifying */			#define VE_NOT_VERIFYING 2 /* we are not verifying */

	void ve_debug_set(int);			void ve_debug_set(int);
	int ve_status_get(int);			int ve_status_get(int);
				void ve_efi_init(void);
				sjgUnsubmitted Not Done Inline Actions can you make sure this is aligned with other prototypes sjg: can you make sure this is aligned with other prototypes
	int load_manifest(const char , const char , const char , struct stat );			int load_manifest(const char , const char , const char , struct stat );
	int verify_file(int, const char *, off_t, int);			int verify_file(int, const char *, off_t, int);
	void verify_pcr_export(void);			void verify_pcr_export(void);

	#endif /* _VERIFY_FILE_H_ */			#endif /* _VERIFY_FILE_H_ */

View Options

sys/amd64/ia32/ia32_reg.c

	Show All 19 Lines
	* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
	* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
	* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
	* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
	*/			*/
	#ifndef _VERIFY_FILE_H_			#ifndef _VERIFY_FILE_H_
	#define _VERIFY_FILE_H_			#define _VERIFY_FILE_H_

				#include <sys/stat.h>
				sjgUnsubmitted Not Done Inline Actions FWIW I just added `struct stat;` but haven't been able to update the review sjg: FWIW I just added `struct stat;` but haven't been able to update the review
				kdAuthorUnsubmitted Not Done Inline Actions Ok, I'll remove it. I supposed that in the end I'll have to rebase on your path after it is merged into the tree. kd: Ok, I'll remove it. I supposed that in the end I'll have to rebase on your path after it is…

	#define VE_GUESS -1 /* let verify_file work it out */			#define VE_GUESS -1 /* let verify_file work it out */
	#define VE_TRY 0 /* we don't mind if unverified */			#define VE_TRY 0 /* we don't mind if unverified */
	#define VE_WANT 1 /* we want this verified */			#define VE_WANT 1 /* we want this verified */
	#define VE_MUST 2 /* this must be verified */			#define VE_MUST 2 /* this must be verified */

	#define VE_VERIFIED 1 /* all good */			#define VE_VERIFIED 1 /* all good */
	#define VE_UNVERIFIED_OK 0 /* not verified but that's ok */			#define VE_UNVERIFIED_OK 0 /* not verified but that's ok */
	#define VE_NOT_VERIFYING 2 /* we are not verifying */			#define VE_NOT_VERIFYING 2 /* we are not verifying */

	void ve_debug_set(int);			void ve_debug_set(int);
	int ve_status_get(int);			int ve_status_get(int);
				void ve_efi_init(void);
				sjgUnsubmitted Not Done Inline Actions can you make sure this is aligned with other prototypes sjg: can you make sure this is aligned with other prototypes
	int load_manifest(const char , const char , const char , struct stat );			int load_manifest(const char , const char , const char , struct stat );
	int verify_file(int, const char *, off_t, int);			int verify_file(int, const char *, off_t, int);
	void verify_pcr_export(void);			void verify_pcr_export(void);

	#endif /* _VERIFY_FILE_H_ */			#endif /* _VERIFY_FILE_H_ */

View Options

sys/amd64/ia32/ia32_signal.c

	Show All 19 Lines
	* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
	* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
	* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
	* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
	*/			*/
	#ifndef _VERIFY_FILE_H_			#ifndef _VERIFY_FILE_H_
	#define _VERIFY_FILE_H_			#define _VERIFY_FILE_H_

				#include <sys/stat.h>
				sjgUnsubmitted Not Done Inline Actions FWIW I just added `struct stat;` but haven't been able to update the review sjg: FWIW I just added `struct stat;` but haven't been able to update the review
				kdAuthorUnsubmitted Not Done Inline Actions Ok, I'll remove it. I supposed that in the end I'll have to rebase on your path after it is merged into the tree. kd: Ok, I'll remove it. I supposed that in the end I'll have to rebase on your path after it is…

	#define VE_GUESS -1 /* let verify_file work it out */			#define VE_GUESS -1 /* let verify_file work it out */
	#define VE_TRY 0 /* we don't mind if unverified */			#define VE_TRY 0 /* we don't mind if unverified */
	#define VE_WANT 1 /* we want this verified */			#define VE_WANT 1 /* we want this verified */
	#define VE_MUST 2 /* this must be verified */			#define VE_MUST 2 /* this must be verified */

	#define VE_VERIFIED 1 /* all good */			#define VE_VERIFIED 1 /* all good */
	#define VE_UNVERIFIED_OK 0 /* not verified but that's ok */			#define VE_UNVERIFIED_OK 0 /* not verified but that's ok */
	#define VE_NOT_VERIFYING 2 /* we are not verifying */			#define VE_NOT_VERIFYING 2 /* we are not verifying */

	void ve_debug_set(int);			void ve_debug_set(int);
	int ve_status_get(int);			int ve_status_get(int);
				void ve_efi_init(void);
				sjgUnsubmitted Not Done Inline Actions can you make sure this is aligned with other prototypes sjg: can you make sure this is aligned with other prototypes
	int load_manifest(const char , const char , const char , struct stat );			int load_manifest(const char , const char , const char , struct stat );
	int verify_file(int, const char *, off_t, int);			int verify_file(int, const char *, off_t, int);
	void verify_pcr_export(void);			void verify_pcr_export(void);

	#endif /* _VERIFY_FILE_H_ */			#endif /* _VERIFY_FILE_H_ */