Page MenuHomeFreeBSD

usb: Add vendor Hygon
ClosedPublic

Authored by puwen_hygon.cn on Feb 7 2020, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 6:26 PM
Unknown Object (File)
Tue, Apr 30, 6:26 PM
Unknown Object (File)
Tue, Apr 30, 6:26 PM
Unknown Object (File)
Tue, Apr 30, 6:26 PM
Unknown Object (File)
Tue, Apr 30, 6:24 PM
Unknown Object (File)
Tue, Apr 30, 3:45 PM
Unknown Object (File)
Feb 19 2024, 11:48 PM
Unknown Object (File)
Jan 11 2024, 9:43 PM
Subscribers

Details

Summary

Show the vendor of the EHCI, OHCI and XHCI USB controller if the
vendor is Hygon.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Hi,

Patch looks good.
Do you have a reference for the new PCI ID values?

--HPS

sys/dev/usb/usbdevs
598

usbdevs is for USB.org ID's . Is 0x1d94 only a PCI ID or is the same value also used for USB?

for future updates please include context - see https://wiki.freebsd.org/Phabricator for info
e.g. one of

git diff -U999999 other-branch > change.diff
git show -U999999 <commit-hash> > change.diff
svn diff --diff-cmd=diff -x -U999999 > change.diff
sys/dev/usb/controller/ehci_pci.c
86

Remain in alpha order

sys/dev/usb/controller/ehci_pci.c
86

This list is sorted alphabetically and this is out of place.

sys/dev/usb/controller/ohci_pci.c
83

This is alphabetically out of place. This list is sorted by vendor name.

sys/dev/usb/usbdevs
598

This is numerically out of place... this list is sorted numerically.

Do you have a reference for the new PCI ID values?

Yes, please reference to:

http://pci-ids.ucw.cz/read/PC/1d94

for future updates please include context - see https://wiki.freebsd.org/Phabricator for info
e.g. one of

git diff -U999999 other-branch > change.diff
git show -U999999 <commit-hash> > change.diff
svn diff --diff-cmd=diff -x -U999999 > change.diff

Thanks, already generate patches with -U999999, and upload the diffs by following "Create a Revision via Web Interface" of https://wiki.freebsd.org/Phabricator. Is the extra context stripped by the web interface? I'll take more care when using the web interface in future.

sys/dev/usb/controller/ehci_pci.c
86

OK, will correct it.

86

OK, will put in the right place.

sys/dev/usb/controller/ohci_pci.c
83

OK, thanks.

sys/dev/usb/usbdevs
598

I'm a little confused here, As AMD USB vendor ID is 0x0438, and there is no 0x1022 in usb.ids, what is AMD2 vendor ID for?

Will remove Hygon USB vendor ID here.

598

OK, thanks.

Show more context.
Sort Hygon constants in order.

sys/dev/usb/usbdevs
598

AMD2:
Vendors may use multiple ID's depending on how many devices they use.

753

Do you have a reference to USB.org for this value?

usbdevs is for USB registered PCI ID's only.

sys/dev/usb/usbdevs
753

We do not have a reference to USB.org for this value. So will remove the value from usbdevs.

puwen_hygon.cn edited the summary of this revision. (Show Details)

Remove Hygon value from usbdevs.

This revision is now accepted and ready to land.Feb 10 2020, 11:06 AM
This revision was automatically updated to reflect the committed changes.