usb: Add vendor Hygon
ClosedPublic
Actions

Authored by puwen_hygon.cn on Feb 7 2020, 10:49 AM.

Details

Reviewers

imp
cem
kib
kevans
manu
• hselasky

Commits

rS358017: MFC r357726:
rS358016: MFC r357726:
rS357726: Add USB host controller PCI ID's for Hygon.

Summary

Show the vendor of the EHCI, OHCI and XHCI USB controller if the
vendor is Hygon.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

puwen_hygon.cn created this revision.Feb 7 2020, 10:49 AM

Hi,

Patch looks good.
Do you have a reference for the new PCI ID values?

--HPS

• hselasky added inline comments.Feb 7 2020, 4:12 PM

sys/dev/usb/usbdevs
598 ↗	(On Diff #67927)	usbdevs is for USB.org ID's . Is 0x1d94 only a PCI ID or is the same value also used for USB?

for future updates please include context - see https://wiki.freebsd.org/Phabricator for info
e.g. one of

git diff -U999999 other-branch > change.diff
git show -U999999 <commit-hash> > change.diff
svn diff --diff-cmd=diff -x -U999999 > change.diff

sys/dev/usb/controller/ehci_pci.c
86 ↗	(On Diff #67927)	Remain in alpha order

imp added inline comments.Feb 7 2020, 4:32 PM

sys/dev/usb/controller/ehci_pci.c
86 ↗	(On Diff #67927)	This list is sorted alphabetically and this is out of place.
sys/dev/usb/controller/ohci_pci.c
83 ↗	(On Diff #67927)	This is alphabetically out of place. This list is sorted by vendor name.
sys/dev/usb/usbdevs
598 ↗	(On Diff #67927)	This is numerically out of place... this list is sorted numerically.

In D23564#517113, @hselasky wrote:

Do you have a reference for the new PCI ID values?

Yes, please reference to:

http://pci-ids.ucw.cz/read/PC/1d94

In D23564#517242, @emaste wrote:
for future updates please include context - see https://wiki.freebsd.org/Phabricator for info
e.g. one of
git diff -U999999 other-branch > change.diff
git show -U999999 <commit-hash> > change.diff
svn diff --diff-cmd=diff -x -U999999 > change.diff

Thanks, already generate patches with -U999999, and upload the diffs by following "Create a Revision via Web Interface" of https://wiki.freebsd.org/Phabricator. Is the extra context stripped by the web interface? I'll take more care when using the web interface in future.

sys/dev/usb/controller/ehci_pci.c
86 ↗	(On Diff #67927)	OK, will correct it.
86 ↗	(On Diff #67927)	OK, will put in the right place.
sys/dev/usb/controller/ohci_pci.c
83 ↗	(On Diff #67927)	OK, thanks.
sys/dev/usb/usbdevs
598 ↗	(On Diff #67927)	I'm a little confused here, As AMD USB vendor ID is 0x0438, and there is no 0x1022 in usb.ids, what is AMD2 vendor ID for? Will remove Hygon USB vendor ID here.
598 ↗	(On Diff #67927)	OK, thanks.

Show more context.
Sort Hygon constants in order.

• hselasky added inline comments.Feb 10 2020, 8:27 AM

sys/dev/usb/usbdevs
753 ↗	(On Diff #68041)	Do you have a reference to USB.org for this value? usbdevs is for USB registered PCI ID's only.
598 ↗	(On Diff #67927)	AMD2: Vendors may use multiple ID's depending on how many devices they use.