Page MenuHomeFreeBSD
Differential D22429

Addition of flag bit definitions in preparation of AccECN
ClosedPublic
Actions

Authored by rscheff on Nov 17 2019, 6:23 AM.
Tags
None
Referenced Files
F82713608: D22429.id.diff
Wed, May 1, 10:28 PM
Unknown Object (File)
Wed, May 1, 12:44 AM
Unknown Object (File)
Sun, Apr 28, 3:41 AM
Unknown Object (File)
Sun, Apr 28, 3:40 AM
Unknown Object (File)
Sun, Apr 28, 3:39 AM
Unknown Object (File)
Sun, Apr 28, 3:38 AM
Unknown Object (File)
Sun, Apr 28, 3:38 AM
Unknown Object (File)
Sat, Apr 27, 10:11 PM
View All 45 Files
Subscribers
imp
melifaro

Details

Reviewers
rgrimes
rrs
tuexen
Group Reviewers
transport
Commits
rS362870: MFC r356227:
rS356227: Add flags for upcoming patches related to improved ECN handling.
Summary

Adding TF flags and SCF (syncache) flags for use with Accurate ECN.
Adding the TCP header Flag for the AE bit, which maps into the upper
portion of the reserved header flags range.
Also marking the last unused flag bit in the TF range, for future use.

These two bits in the TF appear to had prior (~FBSD 5.0, 2003?) use
around some other congestion control (AckCC) mechanism, but were
left unmarked and unclaimed.

This change has no functional changes to existing code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff created this revision.Nov 17 2019, 6:23 AM
Herald added a reviewer: transport. · View Herald TranscriptNov 17 2019, 6:24 AM
Harbormaster completed remote builds in B27602: Diff 64483.Nov 17 2019, 6:24 AM
rscheff updated this revision to Diff 64484.Nov 17 2019, 6:30 AM
  • minimizing delta vs. HEAD (see D22428)
Harbormaster completed remote builds in B27603: Diff 64484.Nov 17 2019, 6:30 AM
rgrimes added a comment.Nov 17 2019, 8:18 AM

Something really strange here with this diff

rscheff added a comment.Nov 17 2019, 8:47 AM
In D22429#490316, @rgrimes wrote:

Something really strange here with this diff

The raw diff should be ok though...

rgrimes accepted this revision.Nov 17 2019, 7:21 PM
In D22429#490320, @rscheff_gmx.at wrote:
In D22429#490316, @rgrimes wrote:

Something really strange here with this diff

The raw diff should be ok though...

Yes, must be a display artifact in Phabricator.

rscheff added inline comments.Nov 21 2019, 9:48 PM
sys/netinet/tcp_var.h
330 ↗(On Diff #64484)

These flags are also being used in other (uncommitted) patches.
Will move all ECN-related Flags to TF2 instead.

rscheff updated this revision to Diff 64697.Nov 21 2019, 10:04 PM
  • remove ACE flag from TF and keep flag bits reserved
Harbormaster completed remote builds in B27697: Diff 64697.Nov 21 2019, 10:04 PM
tuexen accepted this revision.Dec 31 2019, 2:30 PM
This revision is now accepted and ready to land.Dec 31 2019, 2:30 PM
Closed by commit rS356227: Add flags for upcoming patches related to improved ECN handling. (authored by tuexen). · Explain WhyDec 31 2019, 2:33 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rS356227: Add flags for upcoming patches related to improved ECN handling..
Herald added a subscriber: imp. · View Herald TranscriptDec 31 2019, 2:33 PM
tuexen added a commit: rS362870: MFC r356227:.Jul 1 2020, 9:43 PM
Herald added a subscriber: melifaro. · View Herald TranscriptJul 1 2020, 9:43 PM

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
3 lines
4 lines

Diff 66186

View Options

head/sys/netinet/tcp.h

Loading...
View Options

head/sys/netinet/tcp_syncache.h

Loading...