Remove uses of the deprecated timeout_t typedef.
AbandonedPublic
Actions

Authored by jhb on Nov 28 2019, 8:44 PM.

Details

Reviewers

Group Reviewers

Summary

In some cases, remove casts by changing callout functions to accept
a void * argument and adding an assignment to a pointer of the desired
type. In other cases, expand the typedef.

Test Plan

compile tested, booted in an amd64 VM

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27844
Build 26021: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 28 2019, 8:44 PM

Herald added a reviewer: transport. · View Herald TranscriptNov 28 2019, 8:44 PM

Herald added subscribers: donner, bdragon, ae and 2 others. · View Herald Transcript

Harbormaster completed remote builds in B27844: Diff 65025.Nov 28 2019, 8:44 PM

jhb added a child revision: D22602: Remove the deprecated timeout(9) interface..Nov 28 2019, 8:49 PM

I do not object, but what is wrong with the typedef itself ? It is in fact useful, since you have to spell the function pointer type explicitly more than once, esp. in casts.

The typedef itself is for the old API that I'm planning to remove. It's name doesn't make much sense for callout_*(). We could perhaps define a new callout_handler_t or some such in callout.h, but it's not clear to me that would really be better. The only casts here are 2 in uart_core.c. I don't mind renaming the typedef and keeping it for the uart casts (and using it in callout.h and a few other places in follow-on patches), but I don't think the timeout_t name or systm.h header are the right ones going forward.

jhb mentioned this in D22684: Use a void * argument to callout handlers instead of timeout_t casts..Dec 4 2019, 10:12 PM

Superseded by D22751 and D22752.