here (and in headless-utils) having a run depend on nvidia-headless-driver will force the install of the latest nvidia driver which will prevent legacy driver user to install nvidia-hybrid-graphics.
To this I see two solutions: not depending on the nvidia driver so that user can choose the version, or having a slave port with the version like for nvidia-headless-driver

Thanks. Is using FLAVORS for such small variations (that need to be packaged) no longer controversial? If I understand https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/flavors-using.html correctly, this is an intended use (the flavor would be "390" or "legacy")

This seems preferable to either creating more slave port directories or removing the dependency, which would allow installation of a useless hybrid-graphics package and foreseeably cause user frustration (despite a warning in pkg-message).

By not specifying the DISTVERSION to 390.132 the build will use DISTVERSION 440.82 (I don't understand why but it is happening), and then the port name will be nvidia-headless-driver instead of nvidia-headless-driver-390 .
At least that the result that I get using synth, but I think that this should happen to poudriere as well.
At the moment using this fix it

DISTVERSION= 390.132
HEADLESS_MASTERDIR=	${.CURDIR}/../nvidia-headless-driver
PKGNAMESUFFIX=	-390
.include "${HEADLESS_MASTERDIR}/Makefile"

I'm a bit obscured by RUN_DEPENDS= nvidia-headless-utils and using nvidia-headless-utils as MASTERDIR at the same time. Why is this port a slave at all?

I had the two separate ports for two different use-cases:

• Headless graphics. Only the bare minimum for using command-line OpenGL (in future: OpenCL and Vulkan) workflow.
• Hybrid graphics. Real-time rendering to the Intel display, requiring VirtualGL

I thought for the headless case, dependency on a particular nvidia driver version and VirtualGL are extraneous.
But for hybrid graphics case, pulling in all the parts from a single pkg-install on a new desktop installation seems best, thus the dependencies.

The hybrid case is a strict superset of what is needed for headless. It's still a slave port since there is only one github repository for all this.
Probably I should abandon "headless-utils" and just make it an option of hybrid-graphics port?

Probably I should abandon "headless-utils" and just make it an option of hybrid-graphics port?

I think, yes.

Why hiding the directory?

In ports, it should be spelled as .if defined(LIBGLDIR).

Separate NO_LIBMAP thingy looks redundant as it's always aligned LIBGLDIR, no?

Ditto.

Ditto.

Superfluous blank line.

Ditto.

Is the size is so small, perhaps it makes more sense to keep it inside the port's directory like e.g. ports-mgmt/portlint port does?

This is wrong, in Unix, pidfiles are \n-terminated.

This is the existing implementation, both x11/nvidia-driver and x11-servers/xorg-server's install script know about this directory. I merely refactored it to its own variable so nvidia-secondary-driver may override it.
It is moot for the 4xx drivers since 410.057, but still needed for -390 legacy drivers.

Here it seems that exec %%PREFIX%%/libexec/nvidia-settings "$@" is always called, even when there is %%LOCALBASE%%/libexec/nvidia-settings-hybrid

Shouldn't this be
[ -e "%%LOCALBASE%%/libexec/nvidia-settings-hybrid" ] && exec %%LOCALBASE%%/libexec/nvidia-settings-hybrid "$@" || exec %%PREFIX%%/libexec/nvidia-settings "$@"
Instead ?

exec replaces shell process with the new process, therefore the script does not continue and there is no superfluous shell process once libexec/nvidia-settings(-hybrid) is running.

You should be using x_IMPLIES instead: 5.13.3.7. OPT_IMPLIES

As VIRTUALGL is required by OPTIRUN, this is not needed.

DISTVERSION upstream has been bumped to 460.80 so the patch needs to be updated or resync'd to ensure the portname change gets picked up.