Differential D21837

bhyve: refactor NVMe PRP memcpy
ClosedPublic
Actions

Authored by chuck on Sep 29 2019, 3:23 PM.

Tags

None

Referenced Files

	F156844549: D21837.id69922.diff
	Sat, May 16, 8:53 PM

	Unknown Object (File)
	Thu, May 14, 9:06 PM

	Unknown Object (File)
	Mon, May 11, 6:56 PM

	Unknown Object (File)
	Mon, May 11, 3:16 PM

	Unknown Object (File)
	Mon, May 11, 5:54 AM

	Unknown Object (File)
	Mon, May 4, 9:07 AM

	Unknown Object (File)
	Wed, Apr 29, 10:08 AM

	Unknown Object (File)
	Wed, Apr 29, 6:05 AM

Subscribers

Details

Reviewers

imp
ken
jhb

Group Reviewers

Commits

rS359362: bhyve: refactor NVMe PRP memcpy

Summary

Add a "copy direction" parameter to nvme_prp_memcpy such that data can
be copied to the memory specified by the PRP entries (current behavior)
or copied from the PRP entries (new behavior). The upcoming deallocate
functionality will use the copy from capability.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 26762

Event Timeline

chuck created this revision.Sep 29 2019, 3:23 PM

Herald added subscribers: bcran, rgrimes. · View Herald TranscriptSep 29 2019, 3:23 PM

Harbormaster completed remote builds in B26762: Diff 62707.Sep 29 2019, 3:23 PM

chuck mentioned this in D21838: bhyve: refactor NVMe namespace initialization.Sep 29 2019, 3:26 PM

chuck mentioned this in D21839: bhyve: implement NVMe deallocate command.Sep 29 2019, 3:29 PM

jhb accepted this revision.Oct 10 2019, 4:26 PM

This revision is now accepted and ready to land.Oct 10 2019, 4:26 PM

I came here from D21838 to say: looks good too!!! :)

Closed by commit rS359362: bhyve: refactor NVMe PRP memcpy (authored by chuck). · Explain WhyMar 27 2020, 3:28 PM

This revision was automatically updated to reflect the committed changes.

chuck added a commit: rS359362: bhyve: refactor NVMe PRP memcpy.

Herald added a subscriber: dab. · View Herald TranscriptMar 27 2020, 3:28 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

46 lines

Diff 62707

usr.sbin/bhyve/pci_nvme.c

Loading...