Page MenuHomeFreeBSD
Differential D21016

Reduce size of EFI_STAGING_SIZE to 32 on arm
ClosedPublic
Actions

Authored by thj on Jul 21 2019, 7:15 PM.
Tags
None
Referenced Files
F168670117: D21016.id60930.diff
Sat, Aug 29, 1:23 PM
F168668933: D21016.diff
Sat, Aug 29, 1:15 PM
Unknown Object (File)
Sat, Aug 29, 7:17 AM
Unknown Object (File)
Wed, Aug 26, 12:50 PM
Unknown Object (File)
Wed, Aug 26, 11:43 AM
Unknown Object (File)
Wed, Aug 26, 11:43 AM
Unknown Object (File)
Wed, Aug 26, 10:20 AM
Unknown Object (File)
Wed, Aug 26, 9:47 AM
View All Files
Subscribers
andrew
imp
val_packett.cool

Details

Reviewers
manu
bcran
jtl
bz
Commits
rS351166: Reduce size of EFI_STAGING_SIZE to 32 on arm
Summary

Reduce the size of the EFI_STAGING area we allocate on arm7 to 32. On arm SBC such as the NanoPi-NEOLTS the staging area allocation will fail on the 256MB model with a staging size of 64.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25745
Build 24325: arc lint + arc unit

Event Timeline

thj created this revision.Jul 21 2019, 7:15 PM
Harbormaster completed remote builds in B25446: Diff 59994.Jul 21 2019, 7:15 PM
val_packett.cool added a subscriber: val_packett.cool.Jul 21 2019, 7:40 PM

We probably wouldn't want that on big armv8 boxes, maybe || defined(__aarch64__) should be added to if defined(__amd64__) in that case..

thj updated this revision to Diff 60577.Aug 8 2019, 12:57 PM
thj retitled this revision from Reduce size of EFI_STAGING_SIZE to 32 This allows loader to start on the 256MB NanoPi-NEOLTS model to Reduce size of EFI_STAGING_SIZE to 32.
thj edited the summary of this revision. (Show Details)
  • Only reduce staging size on arm
Herald added a subscriber: andrew. · View Herald TranscriptAug 8 2019, 12:57 PM
Harbormaster completed remote builds in B25744: Diff 60577.Aug 8 2019, 12:57 PM
thj updated this revision to Diff 60578.Aug 8 2019, 12:57 PM

Remove accidentally added file

Harbormaster completed remote builds in B25745: Diff 60578.Aug 8 2019, 12:57 PM
bcran accepted this revision.Aug 8 2019, 8:27 PM
This revision is now accepted and ready to land.Aug 8 2019, 8:27 PM
manu accepted this revision.Aug 9 2019, 10:56 AM
thj retitled this revision from Reduce size of EFI_STAGING_SIZE to 32 to Reduce size of EFI_STAGING_SIZE to 32 on arm.Aug 14 2019, 9:03 AM
thj edited the summary of this revision. (Show Details)
thj added reviewers: jtl, bz.
Closed by commit rS351166: Reduce size of EFI_STAGING_SIZE to 32 on arm (authored by thj). · Explain WhyAug 17 2019, 6:48 AM
This revision was automatically updated to reflect the committed changes.
thj added a commit: rS351166: Reduce size of EFI_STAGING_SIZE to 32 on arm.
Herald added a subscriber: imp. · View Herald TranscriptAug 17 2019, 6:48 AM

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
2 lines

Diff 60578

View Options

stand/efi/loader/copy.c

Loading...