Page MenuHomeFreeBSD
Differential D20308

Add initial support for qSupported.
ClosedPublic
Actions

Authored by jhb on May 18 2019, 6:27 PM.
Tags
None
Referenced Files
F163480360: D20308.diff
Thu, Jul 23, 2:56 PM
F163406537: D20308.id.diff
Wed, Jul 22, 10:38 PM
Unknown Object (File)
Tue, Jul 21, 3:28 AM
Unknown Object (File)
Tue, Jul 21, 2:34 AM
Unknown Object (File)
Sat, Jul 18, 9:48 PM
Unknown Object (File)
Sat, Jul 18, 12:06 PM
Unknown Object (File)
Fri, Jul 17, 5:11 PM
Unknown Object (File)
Fri, Jul 3, 10:40 PM
View All Files
Subscribers
bcran
emaste
imp
rgrimes
scottph

Details

Reviewers
scottph
markj
Group Reviewers
bhyve
Commits
rS348253: Add initial support for 'qSupported' to the debug server.
Summary

This doesn't recognize any features yet, but does parse the features
string. It advertises an arbitrary packet size of 4k.

Test Plan
  • this is a prereq for the breakpoint support

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 24305
Build 23128: arc lint + arc unit

Event Timeline

jhb created this revision.May 18 2019, 6:27 PM
Herald added subscribers: bcran, rgrimes, emaste. · View Herald TranscriptMay 18 2019, 6:27 PM
Harbormaster completed remote builds in B24305: Diff 57536.May 18 2019, 6:27 PM
jhb added a parent revision: D20309: Support software breakpoints in the debug server..May 18 2019, 6:32 PM
jhb removed a parent revision: D20309: Support software breakpoints in the debug server..
jhb added a child revision: D20309: Support software breakpoints in the debug server..
jhb added a parent revision: D20307: Add support for writing to guest memory in the debug server..May 18 2019, 6:35 PM
emaste added a comment.May 18 2019, 8:33 PM

LGTM

scottph accepted this revision.May 21 2019, 9:05 PM
scottph added a subscriber: scottph.

Looks good to me

This revision is now accepted and ready to land.May 21 2019, 9:05 PM
markj accepted this revision as: markj.May 22 2019, 8:02 PM
Closed by commit rS348253: Add initial support for 'qSupported' to the debug server. (authored by jhb). · Explain WhyMay 24 2019, 10:11 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 24 2019, 10:11 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
65 lines

Diff 57536

View Options

usr.sbin/bhyve/gdb.c

Loading...