Differential D20308

Add initial support for qSupported.
ClosedPublic
Actions

Authored by jhb on May 18 2019, 6:27 PM.

Details

Reviewers

scottph
markj

Group Reviewers

bhyve

Commits

rS348253: Add initial support for 'qSupported' to the debug server.

Summary

This doesn't recognize any features yet, but does parse the features
string. It advertises an arbitrary packet size of 4k.

Test Plan

this is a prereq for the breakpoint support

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 18 2019, 6:27 PM

Herald added subscribers: bcran, rgrimes, emaste. · View Herald TranscriptMay 18 2019, 6:27 PM

Harbormaster completed remote builds in B24305: Diff 57536.May 18 2019, 6:27 PM

jhb added a parent revision: D20309: Support software breakpoints in the debug server..May 18 2019, 6:32 PM

jhb removed a parent revision: D20309: Support software breakpoints in the debug server..

jhb added a child revision: D20309: Support software breakpoints in the debug server..

jhb added a parent revision: D20307: Add support for writing to guest memory in the debug server..May 18 2019, 6:35 PM

LGTM

Looks good to me

This revision is now accepted and ready to land.May 21 2019, 9:05 PM

markj accepted this revision as: markj.May 22 2019, 8:02 PM

Closed by commit rS348253: Add initial support for 'qSupported' to the debug server. (authored by jhb). · Explain WhyMay 24 2019, 10:11 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 24 2019, 10:11 PM

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyve/

gdb.c

65 lines

Diff 57867

View Options

Add initial support for qSupported.ClosedPublicActions