Page MenuHomeFreeBSD
Differential D20281

Remove resolver_qual from DEFINE_IFUNC/DEFINE_UIFUNC macros.
ClosedPublic
Actions

Authored by kib on May 16 2019, 7:47 PM.
Tags
None
Referenced Files
F138006521: D20281.id57463.diff
Fri, Nov 28, 2:08 AM
Unknown Object (File)
Wed, Nov 26, 8:37 PM
Unknown Object (File)
Tue, Nov 25, 12:22 AM
Unknown Object (File)
Thu, Nov 20, 11:49 PM
Unknown Object (File)
Thu, Nov 20, 11:48 PM
Unknown Object (File)
Thu, Nov 20, 11:46 PM
Unknown Object (File)
Thu, Nov 20, 11:45 PM
Unknown Object (File)
Thu, Nov 20, 11:42 PM
View All Files
Subscribers
andrew
imp
rpokala

Details

Reviewers
emaste
gordon
gnn
jmg
manu
Group Reviewers
secteam
O3: Kernel Random Numbers Generator(Owns No Changed Paths)
Commits
rS347895: Remove resolver_qual from DEFINE_IFUNC/DEFINE_UIFUNC macros.
Summary

In all practical situations, the resolver visibility is static.

Requested by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week

[The reason for review is that I touch dev/random, and commit hook triggers]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 24268

Event Timeline

kib created this revision.May 16 2019, 7:47 PM
Herald added a reviewer: gnn. · View Herald TranscriptMay 16 2019, 7:47 PM
Herald added a reviewer: jmg. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: rpokala, andrew, imp. · View Herald Transcript
Harbormaster completed remote builds in B24266: Diff 57460.May 16 2019, 7:47 PM
emaste added a comment.May 16 2019, 8:48 PM

One ifunc.h has static built-in now and one does not?

sys/amd64/conf/X
89 ↗(On Diff #57460)

?

kib updated this revision to Diff 57463.May 16 2019, 9:33 PM

Fix patch for arm64.

Harbormaster completed remote builds in B24268: Diff 57463.May 16 2019, 9:33 PM
emaste accepted this revision as: emaste.May 16 2019, 10:11 PM

LGTM other than presumably unintentional sys/amd64/conf/X

This revision was not accepted when it landed; it landed in state Needs Review.May 16 2019, 10:21 PM
Closed by commit rS347895: Remove resolver_qual from DEFINE_IFUNC/DEFINE_UIFUNC macros. (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.
Owners added a reviewer: O3: Kernel Random Numbers Generator.May 16 2019, 10:21 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
amd64/
sys/
2 lines
2 lines
2 lines
2 lines
x86/
gen/
4 lines
sys/
2 lines
4 lines
sys/
amd64/
amd64/
32 lines
4 lines
11 lines
26 lines
linux/
10 lines
linux32/
10 lines
arm64/
include/
12 lines
cddl/
dev/
dtrace/
amd64/
14 lines
dev/
random/
2 lines
i386/
i386/
2 lines
3 lines
x86/
include/
14 lines

Diff 57463

View Options

lib/libc/amd64/sys/amd64_get_fsbase.c

Loading...
View Options

lib/libc/amd64/sys/amd64_get_gsbase.c

Loading...
View Options

lib/libc/amd64/sys/amd64_set_fsbase.c

Loading...
View Options

lib/libc/amd64/sys/amd64_set_gsbase.c

Loading...
View Options

lib/libc/x86/gen/getcontextx.c

Loading...
View Options

lib/libc/x86/sys/__vdso_gettc.c

Loading...
View Options

lib/libc/x86/sys/pkru.c

Loading...
View Options

sys/amd64/amd64/copyout.c

Loading...
View Options

sys/amd64/amd64/fpu.c

Loading...
View Options

sys/amd64/amd64/machdep.c

Loading...
View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/amd64/linux/linux_machdep.c

Loading...
View Options

sys/amd64/linux32/linux32_machdep.c

Loading...
View Options

sys/arm64/include/ifunc.h

Loading...
View Options

sys/cddl/dev/dtrace/amd64/dtrace_isa.c

Loading...
View Options

sys/dev/random/ivy.c

Loading...
View Options

sys/i386/i386/npx.c

Loading...
View Options

sys/i386/i386/pmap_base.c

Loading...
View Options

sys/x86/include/ifunc.h

Loading...