Page MenuHomeFreeBSD
Differential D19553

Mk/bsd.sanity.mk: Flag nop options helpers set after bsd.port.options.mk
ClosedPublic
Actions

Authored by tobik on Mar 12 2019, 5:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 4, 6:55 PM
Unknown Object (File)
Thu, Apr 4, 6:55 PM
Unknown Object (File)
Feb 15 2024, 11:40 AM
Unknown Object (File)
Dec 30 2023, 6:13 AM
Unknown Object (File)
Dec 30 2023, 6:13 AM
Unknown Object (File)
Dec 12 2023, 8:05 PM
Unknown Object (File)
Oct 28 2023, 3:28 AM
Unknown Object (File)
Oct 27 2023, 10:49 PM
View All 32 Files
Subscribers
mat
rfyu28uyeg_snkmail.com

Details

Reviewers
None
Group Reviewers
Contributor Reviewers (ports)
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP499267: Flag nop options helpers that appear after bsd.port.options.mk as DEV_ERRORs
Summary

Just last week lang/harbour (rP494667) and www/igal2 (rP495361)
were broken in that regard. It feels like a big waste of time and
energy to raise these issues post commit. Before I open a PR for
portlint about it, maybe the framework itself can flag this as a
problem instead.

Test Plan

I've run make -V DEV_ERROR over the tree. The following ports
currently have problems:

chinese/fcitx
databases/ldb13
databases/ldb14
databases/percona55-client
databases/percona55-server
databases/py-sqlalchemy10
devel/flang
lang/harbour
mail/mimedefang
net/ng_mikrotik_eoip
net-mgmt/pnp
net-mgmt/pnp-icinga2
www/igal2
www/py-bottle-cork

Maybe false positives due to the port defining a variable that looks
like an options helper. These could trivially be fixed by renaming
the variable:

mail/exim		LMDB_LIBS
mail/exim-ldap2
mail/exim-monitor
mail/exim-mysql
mail/exim-postgresql
mail/exim-sa-exim
mail/exim-sqlite
databases/virtuoso	IODBC_CPPFLAGS

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23738
Build 22698: arc lint + arc unit

Event Timeline

tobik created this revision.Mar 12 2019, 5:21 AM
Owners added a reviewer: O5: Ports Framework.Mar 12 2019, 5:21 AM
Herald added a reviewer: portmgr. · View Herald TranscriptMar 12 2019, 5:21 AM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B23027: Diff 54960.Mar 12 2019, 5:21 AM
mat added inline comments.Mar 12 2019, 8:18 PM
Mk/bsd.sanity.mk
303–309

Could you indent the .for/.if?

tobik updated this revision to Diff 55007.Mar 13 2019, 4:32 AM
  • Indent the loop in bsd.sanity.mk too
Harbormaster completed remote builds in B23053: Diff 55007.Mar 13 2019, 4:32 AM
tobik marked an inline comment as done.Mar 13 2019, 4:33 AM
mat added a comment.Mar 13 2019, 7:34 AM

This looks good, let me just have a closer look at it this week.

tobik mentioned this in rP495760: www/igal2: Fix EXIF option.Mar 15 2019, 4:41 AM
tobik mentioned this in rP495761: www/py-bottle-cork: Fix options.
tobik mentioned this in rP495762: net/ng_mikrotik_eoip: Fix PTABLE option.Mar 15 2019, 4:44 AM
tobik mentioned this in rP495763: net-mgmt/pnp: Fix PDF option.Mar 15 2019, 4:50 AM
tobik mentioned this in rP495764: mail/mimedefang: Fix CLAMAV option.Mar 15 2019, 5:02 AM
tobik mentioned this in rP495766: chinese/fcitx: Remove nop options helper.Mar 15 2019, 5:19 AM
tobik mentioned this in rP495774: databases/virtuoso: Replace IODBC_CPPFLAGS and append directly to CPPFLAGS.Mar 15 2019, 8:33 AM
tobik mentioned this in rP495775: devel/flang: Attempt to fix TESTS option.Mar 15 2019, 8:43 AM
tobik mentioned this in rP495779: databases/percona55-server: Attempt to fix OPENSSL option after r446475.Mar 15 2019, 9:05 AM
tobik added a comment.Apr 5 2019, 6:13 AM
In D19553#418840, @mat wrote:

This looks good, let me just have a closer look at it this week.

Did you find any problems with it?

tobik mentioned this in rP497938: databases/py-sqlalchemy10: Drop nop MYSQL option.Apr 5 2019, 6:28 AM
tobik mentioned this in rP497939: databases/ldb1{3,4}: Drop nop options helpers.Apr 5 2019, 6:32 AM
tobik abandoned this revision.Apr 15 2019, 4:00 PM
mat added a comment.Apr 18 2019, 12:53 PM

Sorry about not getting back to you sooner. This looks good, only, please, move the bsd.sanity.mk bits before the UNSUPPORTED/DEPRECATED/... things at the end, with all the .if that exist before.

tobik reclaimed this revision.Apr 18 2019, 1:24 PM

Not sure if I understand correctly where to put it. Let me reclaim and update this.

tobik updated this revision to Diff 56339.Apr 18 2019, 1:26 PM
  • Move it before SANITY_UNSUPPORTED
Harbormaster completed remote builds in B23738: Diff 56339.Apr 18 2019, 1:26 PM
mat accepted this revision as: portmgr.Apr 18 2019, 2:02 PM

Yes, exactly that, thank you.

tobik mentioned this in rP499265: mail/exim: Rename LMDB_LIBS to _LMDB_LIBS.Apr 18 2019, 2:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 18 2019, 2:28 PM
Closed by commit rP499267: Flag nop options helpers that appear after bsd.port.options.mk as DEV_ERRORs (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.
rfyu28uyeg_snkmail.com added a subscriber: rfyu28uyeg_snkmail.com.May 18 2019, 6:27 PM

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237972 to fix some cases of OPENSSL_LDFLAGS (with proposed fix for Uses/ssl.mk).

koobs mentioned this in rP502438: MFH: mail/exim: r499265 r499536.May 24 2019, 9:41 AM

Revision Contents
Changeset List

PathSize
Mk/
21 lines
12 lines

Diff 56339

View Options

Mk/bsd.options.mk

Loading...
View Options

Mk/bsd.sanity.mk

Loading...