Page MenuHomeFreeBSD

Mk/bsd.sanity.mk: Flag nop options helpers set after bsd.port.options.mk
ClosedPublic

Authored by tobik on Mar 12 2019, 5:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 12, 7:49 AM
Unknown Object (File)
Wed, Jan 11, 7:32 PM
Unknown Object (File)
Tue, Jan 10, 4:58 PM
Unknown Object (File)
Sat, Dec 31, 9:47 PM
Unknown Object (File)
Fri, Dec 30, 4:20 AM
Unknown Object (File)
Fri, Dec 30, 4:18 AM
Unknown Object (File)
Fri, Dec 30, 4:17 AM
Unknown Object (File)
Fri, Dec 30, 4:16 AM

Details

Summary

Just last week lang/harbour (rP494667) and www/igal2 (rP495361)
were broken in that regard. It feels like a big waste of time and
energy to raise these issues post commit. Before I open a PR for
portlint about it, maybe the framework itself can flag this as a
problem instead.

Test Plan

I've run make -V DEV_ERROR over the tree. The following ports
currently have problems:

chinese/fcitx
databases/ldb13
databases/ldb14
databases/percona55-client
databases/percona55-server
databases/py-sqlalchemy10
devel/flang
lang/harbour
mail/mimedefang
net/ng_mikrotik_eoip
net-mgmt/pnp
net-mgmt/pnp-icinga2
www/igal2
www/py-bottle-cork

Maybe false positives due to the port defining a variable that looks
like an options helper. These could trivially be fixed by renaming
the variable:

mail/exim		LMDB_LIBS
mail/exim-ldap2
mail/exim-monitor
mail/exim-mysql
mail/exim-postgresql
mail/exim-sa-exim
mail/exim-sqlite
databases/virtuoso	IODBC_CPPFLAGS

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mk/bsd.sanity.mk
291–297 ↗(On Diff #54960)

Could you indent the .for/.if?

  • Indent the loop in bsd.sanity.mk too

This looks good, let me just have a closer look at it this week.

In D19553#418840, @mat wrote:

This looks good, let me just have a closer look at it this week.

Did you find any problems with it?

Sorry about not getting back to you sooner. This looks good, only, please, move the bsd.sanity.mk bits before the UNSUPPORTED/DEPRECATED/... things at the end, with all the .if that exist before.

Not sure if I understand correctly where to put it. Let me reclaim and update this.

  • Move it before SANITY_UNSUPPORTED

Yes, exactly that, thank you.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 18 2019, 2:28 PM
This revision was automatically updated to reflect the committed changes.