Differential D19641

Add bus_release_resource() method to nexus on arm64
ClosedPublic
Actions

Authored by mk_semihalf.com on Mar 19 2019, 1:06 PM.

Tags

Referenced Files

	F81642968: D19641.diff
	Fri, Apr 19, 9:53 AM

	Unknown Object (File)
	Fri, Apr 12, 12:51 AM

	Unknown Object (File)
	Wed, Apr 10, 3:08 AM

	Unknown Object (File)
	Fri, Mar 29, 9:21 AM

	Unknown Object (File)
	Mar 9 2024, 2:08 AM

	Unknown Object (File)
	Feb 21 2024, 6:30 AM

	Unknown Object (File)
	Feb 9 2024, 4:01 PM

	Unknown Object (File)
	Feb 2 2024, 6:41 AM

Subscribers

Details

Reviewers

mw
imp
andrew
manu

Commits

rS345373: Add bus_release_resource() method to nexus on arm64

Summary

The nexus module was missing method for releasing bus resources. As a
result, it couldn't be released and the bus_release_resource() call was
returning ENXIO.

Next call to bus_alloc_resource() for the same resource was returning
error, because it wasn't released previously and it was still busy.

The implementation of the nexus_release_resource() is the same as for
arm architecture.

Test Plan

ifconfig up/down/up on any interface or reload of an module

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mk_semihalf.com created this revision.Mar 19 2019, 1:06 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 19 2019, 1:06 PM

Herald added a subscriber: emaste. · View Herald Transcript

I can confirm that mtu changes on ena work fine with this patch, nice

Works for me. Please commit, unless anyone more familiar with ARMy things says there's a reason why this code was missing...

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2019, 10:51 AM

Closed by commit rS345373: Add bus_release_resource() method to nexus on arm64 (authored by mw). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

nexus.c

17 lines

Diff 55317

View Options

head/sys/arm64/arm64/nexus.c

Add bus_release_resource() method to nexus on arm64ClosedPublicActions