Page MenuHomeFreeBSD
Differential D14154

bsd.gecko.mk: add conditional for ccache
Needs ReviewPublic
Actions

Authored by vishwin on Feb 1 2018, 4:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2024, 9:37 AM
Unknown Object (File)
Dec 21 2023, 3:20 PM
Unknown Object (File)
Dec 20 2023, 12:07 AM
Unknown Object (File)
Dec 9 2023, 7:40 AM
Unknown Object (File)
Nov 19 2023, 3:59 AM
Unknown Object (File)
Nov 17 2023, 1:48 AM
Unknown Object (File)
Nov 14 2023, 8:21 PM
Unknown Object (File)
Nov 11 2023, 11:14 PM
View All 32 Files
Subscribers
grahamperrin
mandree
mat
salvadore
swills

Details

Reviewers
jbeich
salvadore
Group Reviewers
gecko
Summary

See PR 224471. I've been using this since at least a week before I filed that PR with great success.

Test Plan
  • Apply patch, set WITH_CCACHE_BUILD in make.conf
  • Build gecko ports as usual, then build again to utilise the cache

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21175
Build 20530: arc lint + arc unit

Event Timeline

vishwin created this revision.Feb 1 2018, 4:27 AM
Owners added a reviewer: O5: Ports Framework.Feb 1 2018, 4:27 AM
Herald added a reviewer: portmgr. · View Herald TranscriptFeb 1 2018, 4:27 AM
Herald added a subscriber: mat. · View Herald Transcript
swills added a subscriber: swills.Feb 3 2018, 3:59 AM
vishwin updated this revision to Diff 49030.Oct 11 2018, 8:32 PM

Fix conditional, especially when running make config.

Harbormaster completed remote builds in B20147: Diff 49030.Oct 11 2018, 8:32 PM
vishwin updated this revision to Diff 51002.Nov 23 2018, 3:39 PM

Workaround for static ccache in poudriere. /ccache hierarchy isn't in $PATH.

Harbormaster completed remote builds in B21175: Diff 51002.Nov 23 2018, 3:39 PM
salvadore accepted this revision.Jun 17 2019, 10:07 AM
salvadore added a subscriber: salvadore.

I tested successfully the patch for www/firefox.

bapt edited reviewers, added: jbeich; removed: O5: Ports Framework, portmgr.Sep 5 2019, 1:59 PM
This revision is now accepted and ready to land.Sep 5 2019, 1:59 PM
salvadore added a comment.Jan 18 2020, 10:52 AM

This revision is accepted and ready to land since months. Can a committer commit it please?

Thanks!

jbeich added a comment.Feb 27 2020, 4:49 PM

Looks OK in generaly but see inline comments. I've never used ccache with ports and unlikely to do so in future.

Mk/bsd.gecko.mk
150
  • Can you move the whole conditional close to where .if ${PORT_OPTIONS:M...} conditonals are?
  • Don't you need && !defined(NO_CCACHE) like other ports with defined(WITH_CCACHE_BUILD) ?
152

Isn't BUILD_DEPENDS already handled by Mk/bsd.ccache.mk?

vishwin added inline comments.Feb 27 2020, 5:02 PM
Mk/bsd.gecko.mk
152

Unfortunately not in this (edge) case. Especially in poudriere, if using the host's statically-linked ccache, the binary gets copied to the reference jail's /ccache/bin/ccache, which is not in $PATH. The mozilla build system only looks for ccache in $PATH, so without this line, the build fails when using host-based ccache.

mandree added a subscriber: mandree.Oct 11 2020, 3:17 PM
mandree added a comment.Oct 11 2020, 3:24 PM

what needs to happen to get this tested, approved, and moving?

grahamperrin added a subscriber: grahamperrin.Apr 23 2023, 12:38 PM

Is this still accepted as it was in 2019?

If not – if a change is inarguably required: please, can someone suggest a change to the code?

Many thanks

salvadore resigned from this revision.Apr 23 2023, 12:42 PM

After about 4 years since my tests, I have no idea if this patch still works or not. It should be tested again, but unfortunately I do not have the time to do it. I hope someone else will be able to do it.

This revision now requires review to proceed.Apr 23 2023, 12:42 PM

Revision Contents
Changeset List

PathSize
Mk/
5 lines

Diff 51002

View Options

Mk/bsd.gecko.mk

Loading...