bsd.gecko.mk: add conditional for ccache

[vishwin]

Summary

See PR 224471. I've been using this since at least a week before I filed that PR with great success.

Test Plan

• Apply patch, set WITH_CCACHE_BUILD in make.conf
• Build gecko ports as usual, then build again to utilise the cache

[vishwin]

Fix conditional, especially when running make config.

[vishwin]

Workaround for static ccache in poudriere. /ccache hierarchy isn't in $PATH.

[salvadore]

I tested successfully the patch for www/firefox.

[salvadore]

This revision is accepted and ready to land since months. Can a committer commit it please?

Thanks!

[jbeich]

Looks OK in generaly but see inline comments. I've never used ccache with ports and unlikely to do so in future.

Mk/bsd.gecko.mk

166

• Can you move the whole conditional close to where .if ${PORT_OPTIONS:M...} conditonals are?
• Don't you need && !defined(NO_CCACHE) like other ports with defined(WITH_CCACHE_BUILD) ?

168

Isn't BUILD_DEPENDS already handled by Mk/bsd.ccache.mk?

[vishwin]

Mk/bsd.gecko.mk

168

Unfortunately not in this (edge) case. Especially in poudriere, if using the host's statically-linked ccache, the binary gets copied to the reference jail's /ccache/bin/ccache, which is not in $PATH. The mozilla build system only looks for ccache in $PATH, so without this line, the build fails when using host-based ccache.

[mandree]

what needs to happen to get this tested, approved, and moving?

[grahamperrin]

Is this still accepted as it was in 2019?

If not – if a change is inarguably required: please, can someone suggest a change to the code?

Many thanks

[salvadore]

After about 4 years since my tests, I have no idea if this patch still works or not. It should be tested again, but unfortunately I do not have the time to do it. I hope someone else will be able to do it.