Page MenuHomeFreeBSD
Differential D17541

update ZFS to note support of extended attributes
AcceptedPublic
Actions

Authored by jmg on Oct 12 2018, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 4:49 PM
Unknown Object (File)
Thu, Apr 25, 2:18 PM
Unknown Object (File)
Wed, Apr 17, 7:57 PM
Unknown Object (File)
Oct 12 2023, 7:28 AM
Unknown Object (File)
Mar 21 2023, 8:02 PM
Unknown Object (File)
Mar 3 2023, 11:53 PM
Unknown Object (File)
Nov 28 2022, 4:46 AM
Subscribers
allanjude
debdrup
delphij
emaste
imp

Details

Reviewers
freqlabs
Group Reviewers
manpages

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20171
Build 19657: arc lint + arc unit

Event Timeline

jmg created this revision.Oct 12 2018, 10:38 PM
Herald added a reviewer: manpages. · View Herald TranscriptOct 12 2018, 10:38 PM
Herald added subscribers: delphij, imp. · View Herald Transcript
Harbormaster completed remote builds in B20171: Diff 49078.Oct 12 2018, 10:38 PM
delphij added inline comments.Oct 12 2018, 10:55 PM
cddl/contrib/opensolaris/cmd/zfs/zfs.8
1565

Maybe rephrase this to something like, xattrs=off has no effect on .Fx? Looking at the code it seems like that we basically ignored xattr=off due to lack of VFS_XATTR?

debdrup added a subscriber: debdrup.EditedOct 12 2018, 11:16 PM

For posterity's sake, the context of this review is a conversation on Twitter regarding the state of xattr/EA in FreeBSD for ZFS, with a special eye to multi-labels.

emaste added a subscriber: emaste.Jan 30 2019, 7:55 PM
allanjude added a reviewer: freqlabs.Jul 17 2020, 4:50 PM
allanjude added a subscriber: allanjude.

Ryan has been working on commonize-ing some of the way this works upstream in OpenZFS, he may have useful input.

jmg added a comment.Jul 17 2020, 7:02 PM

@freqlabs let ms know if you just want to integrate this into the OpenZFS update, or what.

Thanks.

freqlabs added a comment.Jul 17 2020, 7:05 PM

Yes a PR clarifying this in OpenZFS would be greatly appreciated. Any change here would only be good for MFC. I think the wording suggested by @delphij is a bit more clear.

jmg added a comment.Jul 17 2020, 8:01 PM
In D17541#569015, @freqlabs wrote:

Yes a PR clarifying this in OpenZFS would be greatly appreciated. Any change here would only be good for MFC. I think the wording suggested by @delphij is a bit more clear.

Well, it looks like OpenZFS's zfsprops.8 doesn't have the wording that FreeBSD doesn't support xattr. and it looks generic that it doesn't leave any OS specific changes, so I won't be submitting anything to OpenZFS for this change.

freqlabs accepted this revision.Jul 20 2020, 8:32 PM

Fix the date of course.

This revision is now accepted and ready to land.Jul 20 2020, 8:32 PM

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
cmd/
zfs/
6 lines

Diff 49078

View Options

cddl/contrib/opensolaris/cmd/zfs/zfs.8

Loading...