Details

Reviewers

eugen_grosbein.net
bapt
• ian
dab
dch
allanjude

Commits

rS339534: pw: fix the checks in boolean_str() after r326738. Add related test

Summary

PR: 231649

boolean_str() has weird ideas about the possible values of val, make them match reality.

Test Plan

# /usr/obj/home/yuri/ws/pw/amd64.amd64/usr.sbin/pw/pw useradd -D -w no; grep defaultpasswd /etc/pw.conf
defaultpasswd = "no"
# /usr/obj/home/yuri/ws/pw/amd64.amd64/usr.sbin/pw/pw useradd -D -w none; grep defaultpasswd /etc/pw.conf
defaultpasswd = "none"
# /usr/obj/home/yuri/ws/pw/amd64.amd64/usr.sbin/pw/pw useradd -D -w random; grep defaultpasswd /etc/pw.conf
defaultpasswd = "random"
# /usr/obj/home/yuri/ws/pw/amd64.amd64/usr.sbin/pw/pw useradd -D -w yes; grep defaultpasswd /etc/pw.conf
defaultpasswd = "yes"
# /usr/obj/home/yuri/ws/pw/amd64.amd64/usr.sbin/pw/pw useradd -D -w whoa; grep defaultpasswd /etc/pw.conf
pw: Invalid value for default password
defaultpasswd = "yes"

Also, newly added test cases:

...
usr.sbin/pw/pw_useradd_test:user_add_conf_defaultpasswd  ->  passed  [0.089s]
...

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

yuripv created this revision.Sep 24 2018, 3:49 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptSep 24 2018, 3:49 AM

yuripv edited the test plan for this revision. (Show Details)Sep 24 2018, 3:49 AM

add test case

add fix for PR231653 helping added test cases

emaste added a subscriber: emaste.Sep 24 2018, 11:10 PM

Just as a comment: boolean_str() problem seems to be a left-over after my change r326848 that changed magic values -2 .. 1 to symbols P_NONE etc. but missed a change for boolean_str().

eugen_grosbein.net accepted this revision.Sep 30 2018, 10:56 AM

eugen_grosbein.net added a reviewer: eugen_grosbein.net.

This revision is now accepted and ready to land.Sep 30 2018, 10:56 AM