Page MenuHomeFreeBSD

acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic
ClosedPublic

Authored by jason_eggnet.com on Jul 9 2018, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 10, 2:24 AM
Unknown Object (File)
Mon, Mar 9, 7:56 PM
Unknown Object (File)
Sun, Mar 8, 11:57 AM
Unknown Object (File)
Fri, Mar 6, 9:10 AM
Unknown Object (File)
Tue, Mar 3, 2:59 PM
Unknown Object (File)
Tue, Mar 3, 3:31 AM
Unknown Object (File)
Mon, Mar 2, 2:47 AM
Unknown Object (File)
Feb 2 2026, 1:14 PM
Subscribers

Details

Summary

Hopefully simple fix to address panics relating to setting IPV6_TCLASS with setsockopt().

The premise of this fix is that it is ok to call malloc with M_NOWAIT while holding a lock on the in6p.

If it is not ok, then major surgery will be required, as ip6_setpktopt() will have to be fixed (as it also calls malloc with M_NOWAIT) which pulls in the ip6_pcbopts(), ip6_setpktopts(), ip6_setpktopt() call chain. The other call chain does have to be fixed but it can be done in a different review (and with relative ease) if this strategy works out.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17942
Build 17697: arc lint + arc unit