Page MenuHomeFreeBSD
Differential D14953

Remove architecture specific sigreturn.S files.
ClosedPublic
Actions

Authored by brooks on Apr 3 2018, 6:24 PM.
Tags
None
Referenced Files
F163271405: D14953.id41040.diff
Tue, Jul 21, 3:18 PM
Unknown Object (File)
Mon, Jul 20, 1:50 PM
Unknown Object (File)
Sat, Jul 18, 6:59 PM
Unknown Object (File)
Sat, Jul 18, 12:02 PM
Unknown Object (File)
Tue, Jul 7, 11:46 PM
Unknown Object (File)
Sat, Jul 4, 6:27 PM
Unknown Object (File)
Thu, Jul 2, 5:10 AM
Unknown Object (File)
Mon, Jun 29, 11:35 PM
View All Files
Subscribers
ali_mashtizadeh.com
emaste
imp

Details

Reviewers
br
andrew
kib
jhb
Commits
rS332048: Remove architecture specific sigreturn.S files.
Summary

All of these files are identical (modulo license blocks and VCS IDs) to
the files generated by lib/libc/sys/Makefile.inc and serve no purpose.

Test Plan

universe build

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15967
Build 15956: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 3 2018, 6:24 PM
Herald added a subscriber: emaste. · View Herald TranscriptApr 3 2018, 6:24 PM
Harbormaster completed remote builds in B15961: Diff 41040.Apr 3 2018, 6:24 PM
kib added a comment.Apr 3 2018, 7:56 PM

Can you show me the output of
readelf -l /lib/libc.so.7
for the patched library ?

brooks updated this revision to Diff 41057.Apr 3 2018, 9:20 PM
  • Work correctly in a clean tree.
Harbormaster completed remote builds in B15967: Diff 41057.Apr 3 2018, 9:20 PM
brooks added a comment.Apr 3 2018, 9:21 PM
In D14953#314405, @kib wrote:

Can you show me the output of
readelf -l /lib/libc.so.7
for the patched library ?

See paste P162

ali_mashtizadeh.com added a subscriber: ali_mashtizadeh.com.Apr 3 2018, 9:23 PM
kib accepted this revision.Apr 3 2018, 9:39 PM
This revision is now accepted and ready to land.Apr 3 2018, 9:39 PM
Closed by commit rS332048: Remove architecture specific sigreturn.S files. (authored by brooks). · Explain WhyApr 4 2018, 10:45 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptApr 4 2018, 10:45 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
sys/
1 line
amd64/
sys/
2 lines
arm/
sys/
2 lines
i386/
sys/
2 lines
riscv/
sys/
1 line

Diff 41057

View Options

lib/libc/aarch64/sys/Makefile.inc

Loading...
View Options

lib/libc/aarch64/sys/sigreturn.S

Loading...
View Options

lib/libc/amd64/sys/Makefile.inc

Loading...
View Options

lib/libc/amd64/sys/sigreturn.S

Loading...
View Options

lib/libc/arm/sys/Makefile.inc

Loading...
View Options

lib/libc/arm/sys/sigreturn.S

Loading...
View Options

lib/libc/i386/sys/Makefile.inc

Loading...
View Options

lib/libc/i386/sys/sigreturn.S

Loading...
View Options

lib/libc/riscv/sys/Makefile.inc

Loading...
View Options

lib/libc/riscv/sys/sigreturn.S

Loading...