Page MenuHomeFreeBSD
Differential D14953

Remove architecture specific sigreturn.S files.
ClosedPublic
Actions

Authored by brooks on Apr 3 2018, 6:24 PM.
Tags
None
Referenced Files
F147169230: D14953.id41112.diff
Sun, Mar 8, 7:43 PM
Unknown Object (File)
Sun, Mar 8, 6:32 AM
Unknown Object (File)
Thu, Feb 26, 2:13 PM
Unknown Object (File)
Thu, Feb 26, 11:16 AM
Unknown Object (File)
Tue, Feb 24, 7:28 PM
Unknown Object (File)
Mon, Feb 16, 4:24 AM
Unknown Object (File)
Sun, Feb 15, 2:34 PM
Unknown Object (File)
Fri, Feb 13, 1:04 PM
View All Files
Subscribers
ali_mashtizadeh.com
emaste
imp

Details

Reviewers
br
andrew
kib
jhb
Commits
rS332048: Remove architecture specific sigreturn.S files.
Summary

All of these files are identical (modulo license blocks and VCS IDs) to
the files generated by lib/libc/sys/Makefile.inc and serve no purpose.

Test Plan

universe build

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Apr 3 2018, 6:24 PM
Herald added a subscriber: emaste. · View Herald TranscriptApr 3 2018, 6:24 PM
Harbormaster completed remote builds in B15961: Diff 41040.Apr 3 2018, 6:24 PM
kib added a comment.Apr 3 2018, 7:56 PM

Can you show me the output of
readelf -l /lib/libc.so.7
for the patched library ?

brooks updated this revision to Diff 41057.Apr 3 2018, 9:20 PM
  • Work correctly in a clean tree.
Harbormaster completed remote builds in B15967: Diff 41057.Apr 3 2018, 9:20 PM
brooks added a comment.Apr 3 2018, 9:21 PM
In D14953#314405, @kib wrote:

Can you show me the output of
readelf -l /lib/libc.so.7
for the patched library ?

See paste P162

ali_mashtizadeh.com added a subscriber: ali_mashtizadeh.com.Apr 3 2018, 9:23 PM
kib accepted this revision.Apr 3 2018, 9:39 PM
This revision is now accepted and ready to land.Apr 3 2018, 9:39 PM
Closed by commit rS332048: Remove architecture specific sigreturn.S files. (authored by brooks). · Explain WhyApr 4 2018, 10:45 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptApr 4 2018, 10:45 PM

Revision Contents
Changeset List

PathSize
head/
lib/
libc/
aarch64/
sys/
1 line
35 lines
amd64/
sys/
2 lines
48 lines
arm/
sys/
2 lines
44 lines
i386/
sys/
2 lines
48 lines
riscv/
sys/
1 line
40 lines

Diff 41112

View Options

head/lib/libc/aarch64/sys/Makefile.inc

Loading...
View Options

head/lib/libc/aarch64/sys/sigreturn.S

Loading...
View Options

head/lib/libc/amd64/sys/Makefile.inc

Loading...
View Options

head/lib/libc/amd64/sys/sigreturn.S

Loading...
View Options

head/lib/libc/arm/sys/Makefile.inc

Loading...
View Options

head/lib/libc/arm/sys/sigreturn.S

Loading...
View Options

head/lib/libc/i386/sys/Makefile.inc

Loading...
View Options

head/lib/libc/i386/sys/sigreturn.S

Loading...
View Options

head/lib/libc/riscv/sys/Makefile.inc

Loading...
View Options

head/lib/libc/riscv/sys/sigreturn.S

Loading...