Fix comparing L3 type with L4 enum on RX hash in ENA driver
ClosedPublic
Actions

Authored by mk_semihalf.com on Oct 31 2017, 1:48 PM.

Tags

None

Referenced Files

	F131616182: D12867.id.diff
	Thu, Oct 9, 6:57 PM

	Unknown Object (File)
	Wed, Oct 8, 3:54 PM

	Unknown Object (File)
	Thu, Oct 2, 2:51 PM

	Unknown Object (File)
	Tue, Sep 30, 10:03 AM

	Unknown Object (File)
	Sat, Sep 27, 3:47 AM

	Unknown Object (File)
	Fri, Sep 19, 8:27 AM

	Unknown Object (File)
	Sun, Sep 14, 9:20 PM

	Unknown Object (File)
	Thu, Sep 11, 12:20 PM

View All 96 Files

Subscribers

gtzalik_amazon.com

imp

Details

Reviewers

rlibby
byenduri_gmail.com
mw

Commits

rS325587: Fix comparing L3 type with L4 enum on RX hash in ENA driver

Summary

This bug wasn't impacting anything, because both enums are indicating
the same value, but it could cause a problem on API change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mk_semihalf.com created this revision.Oct 31 2017, 1:48 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 31 2017, 1:48 PM

mk_semihalf.com added a parent revision: D12866: Fix compilation warnings when building ENA driver with gcc compiler.Oct 31 2017, 1:48 PM

mk_semihalf.com added a child revision: D12868: Rework printouts and logging level in ENA driver.Oct 31 2017, 1:54 PM

byenduri_gmail.com accepted this revision.Nov 7 2017, 2:23 AM

This revision is now accepted and ready to land.Nov 7 2017, 2:23 AM

Closed by commit rS325587: Fix comparing L3 type with L4 enum on RX hash in ENA driver (authored by mw). · Explain WhyNov 9 2017, 12:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ena/

ena.c

2 lines

Diff 34991

View Options

Fix comparing L3 type with L4 enum on RX hash in ENA driverClosedPublicActions