Fix error handling in the ENA driver and lock drbr_free() call
ClosedPublic
Actions

Authored by mk_semihalf.com on Oct 31 2017, 1:37 PM.

Details

Reviewers

mw
rlibby
byenduri_gmail.com

Commits

rS325579: Fix error handling in the ENA driver and lock drbr_free() call

Summary

Some goto tags were renamed for consistency, and few error handling
routines were reworked.

The drbr_free() must be locked just in case code will change in the
future - for now, it should never be an issue, because drbr is being
flushed in the ena_down() call, and the lock is required only when there
are some mbufs inside.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mk_semihalf.com created this revision.Oct 31 2017, 1:37 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 31 2017, 1:37 PM

mk_semihalf.com added a parent revision: D12858: Destroy admin queue after freeing interrupts in ENA driver.Oct 31 2017, 1:37 PM

mk_semihalf.com added a child revision: D12860: Refactor style of the ENA driver.Oct 31 2017, 1:40 PM

Update due to conflict with recent fix in the:
D12853 Fix ENA driver error handling in attach and basic style fixes

Looks good to me.

This revision is now accepted and ready to land.Nov 7 2017, 9:52 PM

Closed by commit rS325579: Fix error handling in the ENA driver and lock drbr_free() call (authored by mw). · Explain WhyNov 9 2017, 11:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ena/

ena.c

94 lines

Diff 34983

View Options

Fix error handling in the ENA driver and lock drbr_free() callClosedPublicActions