bhyve: actually call bhyve_caph_cache_catpages
ClosedPublic
Actions

Authored by rlibby on Sep 1 2017, 11:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 20, 1:39 AM

	Unknown Object (File)
	Fri, Apr 19, 12:44 PM

	Unknown Object (File)
	Fri, Apr 19, 4:44 AM

	Unknown Object (File)
	Thu, Apr 18, 12:07 PM

	Unknown Object (File)
	Feb 19 2024, 2:23 AM

	Unknown Object (File)
	Jan 20 2024, 6:26 AM

	Unknown Object (File)
	Dec 21 2023, 11:13 AM

	Unknown Object (File)
	Oct 11 2023, 8:58 PM

Subscribers

Details

Reviewers

grehan

Commits

rS323427: bhyve: actually call bhyve_caph_cache_catpages

Summary

Gcc noticed that bhyve_caph_cache_catpages was defined but unused. It is a stable/11 copy of caph_cache_catpages in head. In head, caph_cache_catpages is called where I have here inserted a call to bhyve_caph_cache_catpages, assuming that was the intention. An alternative fix may be to delete bhyve_caph_cache_catpages entirely.

Direct commit to stable/11. This bug does not apply to head.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11339
Build 11704: arc lint + arc unit

Event Timeline

rlibby created this revision.Sep 1 2017, 11:44 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2017, 11:44 PM

Harbormaster completed remote builds in B11339: Diff 32603.Sep 1 2017, 11:44 PM

Thanks - this keeps the behviour in sync with head where the routines are hidden in caph helpers, so my opinion is it is best to keep the catpages call.

This revision is now accepted and ready to land.Sep 5 2017, 5:35 AM

Approved

Closed by commit rS323427: bhyve: actually call bhyve_caph_cache_catpages (authored by rlibby). · Explain WhySep 11 2017, 7:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

bhyverun.c

2 lines

Diff 32603

View Options

bhyve: actually call bhyve_caph_cache_catpagesClosedPublicActions