Page MenuHomeFreeBSD

bhyve: actually call bhyve_caph_cache_catpages
ClosedPublic

Authored by rlibby on Sep 1 2017, 11:44 PM.
Tags
None
Referenced Files
F81654175: D12212.id32915.diff
Fri, Apr 19, 12:44 PM
F81625932: D12212.diff
Fri, Apr 19, 4:44 AM
Unknown Object (File)
Thu, Apr 18, 12:07 PM
Unknown Object (File)
Feb 19 2024, 2:23 AM
Unknown Object (File)
Jan 20 2024, 6:26 AM
Unknown Object (File)
Dec 21 2023, 11:13 AM
Unknown Object (File)
Oct 11 2023, 8:58 PM
Unknown Object (File)
Sep 16 2023, 12:31 AM

Details

Summary

Gcc noticed that bhyve_caph_cache_catpages was defined but unused. It is a stable/11 copy of caph_cache_catpages in head. In head, caph_cache_catpages is called where I have here inserted a call to bhyve_caph_cache_catpages, assuming that was the intention. An alternative fix may be to delete bhyve_caph_cache_catpages entirely.

Direct commit to stable/11. This bug does not apply to head.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks - this keeps the behviour in sync with head where the routines are hidden in caph helpers, so my opinion is it is best to keep the catpages call.

This revision is now accepted and ready to land.Sep 5 2017, 5:35 AM
This revision was automatically updated to reflect the committed changes.