Page MenuHomeFreeBSD

bhyve: actually call bhyve_caph_cache_catpages
ClosedPublic

Authored by rlibby on Sep 1 2017, 11:44 PM.

Details

Summary

Gcc noticed that bhyve_caph_cache_catpages was defined but unused. It is a stable/11 copy of caph_cache_catpages in head. In head, caph_cache_catpages is called where I have here inserted a call to bhyve_caph_cache_catpages, assuming that was the intention. An alternative fix may be to delete bhyve_caph_cache_catpages entirely.

Direct commit to stable/11. This bug does not apply to head.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11339
Build 11704: arc lint + arc unit

Event Timeline

rlibby created this revision.Sep 1 2017, 11:44 PM
grehan accepted this revision.Sep 5 2017, 5:35 AM

Thanks - this keeps the behviour in sync with head where the routines are hidden in caph helpers, so my opinion is it is best to keep the catpages call.

This revision is now accepted and ready to land.Sep 5 2017, 5:35 AM
This revision was automatically updated to reflect the committed changes.