Page MenuHomeFreeBSD

Get rid of QT_PREFIX in favour of PREFIX
ClosedPublic

Authored by tcberner on Dec 17 2016, 12:13 PM.
Tags
None
Referenced Files
F82035085: D8825.diff
Wed, Apr 24, 8:34 PM
Unknown Object (File)
Tue, Apr 16, 10:31 AM
Unknown Object (File)
Tue, Apr 16, 6:53 AM
Unknown Object (File)
Fri, Apr 12, 7:25 PM
Unknown Object (File)
Thu, Apr 11, 9:13 AM
Unknown Object (File)
Thu, Apr 11, 1:23 AM
Unknown Object (File)
Mon, Apr 8, 11:00 PM
Unknown Object (File)
Mon, Apr 8, 10:24 PM
Subscribers

Details

Summary

I don't see a reason to have our own QT_PREFIX variable.
I think it is more sensible to use PREFIX.

Test Plan
  • test [some] affected ports with poudriere -P
  • exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6286
Build 6526: arc lint + arc unit

Event Timeline

tcberner retitled this revision from to Get rid of QT_PREFIX in favour of PREFIX.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, mat, rakuco, adridg.

I did not have the patience to wait for editors/libreoffice* to finish. The rest of the affected ports were fine.

rakuco edited edge metadata.

Looks good to me. The use of QT_PREFIX seems to date back to the days we had Qt 3 and Qt 4 in the tree (the latter still being worked on) and Qt3 installed into ${X11BASE}.

Make sure you add an entry to CHANGES too.

multimedia/phonon/pkg-plist
187

I think it makes sense to re-sort the plist now.

This revision was automatically updated to reflect the committed changes.

This was broken, as PREFIX is used where LOCALBASE was and should have used.