Fix QT_PREFIX removal fallout: use LOCALBASE instead of PREFIX

[AMDmi3]

Summary

In D8825 which removed QT_PREFIX it was incorrectly replaced with PREFIX, while it should've been LOCALBASE in most places. Fix this.

First version of this is a raw mechanical patch, not yet properly tested.

[tcberner]

Can you explain what the issue with using PREFIX over LOCALBASE is?

[AMDmi3]

In D10010#206805, @tcberner wrote:

Can you explain what the issue with using PREFIX over LOCALBASE is?

When you refer to what current port installs, you must use PREFIX.
When you refer to files installed by other ports, you must use LOCALBASE.

It's a bit more complex when port wants to install files to QT owned dirs, and looking at plist changes I suspect this happens somehere. If that's the case, plist should use full paths.

[rakuco]

Looks sane to me, though as you said it might be tricky for ports installing things into Qt-owned directories. Is there an easy way to test this in, say, Poudriere?

Mk/bsd.qt.mk

273

If you really want to be thorough here, this likely needs to be ${PREFIX} for ports setting QT_DIST (since they're Qt ports installing into Qt directories), and ${LOCALBASE} for others.