Page MenuHomeFreeBSD

Get rid of QT_PREFIX in favour of PREFIX
ClosedPublic

Authored by tcberner on Dec 17 2016, 12:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 4, 6:37 AM
Unknown Object (File)
Sat, Jun 29, 3:52 PM
Unknown Object (File)
Wed, Jun 26, 3:29 PM
Unknown Object (File)
Fri, Jun 21, 4:31 AM
Unknown Object (File)
Fri, Jun 21, 3:23 AM
Unknown Object (File)
May 28 2024, 10:38 PM
Unknown Object (File)
May 22 2024, 6:23 PM
Unknown Object (File)
May 20 2024, 1:52 AM
Subscribers

Details

Summary

I don't see a reason to have our own QT_PREFIX variable.
I think it is more sensible to use PREFIX.

Test Plan
  • test [some] affected ports with poudriere -P
  • exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner retitled this revision from to Get rid of QT_PREFIX in favour of PREFIX.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, mat, rakuco, adridg.

I did not have the patience to wait for editors/libreoffice* to finish. The rest of the affected ports were fine.

rakuco edited edge metadata.

Looks good to me. The use of QT_PREFIX seems to date back to the days we had Qt 3 and Qt 4 in the tree (the latter still being worked on) and Qt3 installed into ${X11BASE}.

Make sure you add an entry to CHANGES too.

multimedia/phonon/pkg-plist
187 ↗(On Diff #23024)

I think it makes sense to re-sort the plist now.

This revision was automatically updated to reflect the committed changes.

This was broken, as PREFIX is used where LOCALBASE was and should have used.