I don't see a reason to have our own QT_PREFIX variable.
I think it is more sensible to use PREFIX.
Details
Details
- Reviewers
adridg rakuco mat - Group Reviewers
O5: Ports Framework portmgr kde - Commits
- rP428889: Get rid of QT_PREFIX in favour of PREFIX.
- test [some] affected ports with poudriere -P
- exp-run
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I did not have the patience to wait for editors/libreoffice* to finish. The rest of the affected ports were fine.
Comment Actions
Looks good to me. The use of QT_PREFIX seems to date back to the days we had Qt 3 and Qt 4 in the tree (the latter still being worked on) and Qt3 installed into ${X11BASE}.
Make sure you add an entry to CHANGES too.
multimedia/phonon/pkg-plist | ||
---|---|---|
187 ↗ | (On Diff #23024) | I think it makes sense to re-sort the plist now. |