Page MenuHomeFreeBSD

Get rid of QT_PREFIX in favour of PREFIX
ClosedPublic

Authored by tcberner on Dec 17 2016, 12:13 PM.
Tags
None
Referenced Files
F164269880: D8825.id23067.diff
Thu, Jul 30, 6:15 AM
F164254750: D8825.id23024.diff
Thu, Jul 30, 3:43 AM
Unknown Object (File)
Mon, Jul 27, 11:48 AM
Unknown Object (File)
Mon, Jul 27, 8:03 AM
Unknown Object (File)
Fri, Jul 24, 11:57 AM
Unknown Object (File)
Thu, Jul 23, 2:22 PM
Unknown Object (File)
Wed, Jul 22, 2:35 AM
Unknown Object (File)
Sun, Jul 19, 3:03 PM
Subscribers

Details

Summary

I don't see a reason to have our own QT_PREFIX variable.
I think it is more sensible to use PREFIX.

Test Plan
  • test [some] affected ports with poudriere -P
  • exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner retitled this revision from to Get rid of QT_PREFIX in favour of PREFIX.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, mat, rakuco, adridg.

I did not have the patience to wait for editors/libreoffice* to finish. The rest of the affected ports were fine.

rakuco edited edge metadata.

Looks good to me. The use of QT_PREFIX seems to date back to the days we had Qt 3 and Qt 4 in the tree (the latter still being worked on) and Qt3 installed into ${X11BASE}.

Make sure you add an entry to CHANGES too.

multimedia/phonon/pkg-plist
187 ↗(On Diff #23024)

I think it makes sense to re-sort the plist now.

This revision was automatically updated to reflect the committed changes.

This was broken, as PREFIX is used where LOCALBASE was and should have used.