Page MenuHomeFreeBSD

Get rid of QT_PREFIX in favour of PREFIX
ClosedPublic

Authored by tcberner on Dec 17 2016, 12:13 PM.

Details

Summary

I don't see a reason to have our own QT_PREFIX variable.
I think it is more sensible to use PREFIX.

Test Plan
  • test [some] affected ports with poudriere -P
  • exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner retitled this revision from to Get rid of QT_PREFIX in favour of PREFIX.Dec 17 2016, 12:13 PM
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, mat, rakuco, adridg.
tcberner updated this revision to Diff 23024.

I did not have the patience to wait for editors/libreoffice* to finish. The rest of the affected ports were fine.

rakuco edited edge metadata.Dec 18 2016, 3:51 PM
rakuco accepted this revision.

Looks good to me. The use of QT_PREFIX seems to date back to the days we had Qt 3 and Qt 4 in the tree (the latter still being worked on) and Qt3 installed into ${X11BASE}.

Make sure you add an entry to CHANGES too.

multimedia/phonon/pkg-plist
187 ↗(On Diff #23024)

I think it makes sense to re-sort the plist now.

This revision was automatically updated to reflect the committed changes.
AMDmi3 added a subscriber: AMDmi3.Mar 15 2017, 9:29 AM

This was broken, as PREFIX is used where LOCALBASE was and should have used.