Page MenuHomeFreeBSD
Differential D8602

Update the dependency code in bsd.qt.mk to the one from kde.mk
ClosedPublic
Actions

Authored by tcberner on Nov 21 2016, 11:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 7, 1:33 PM
Unknown Object (File)
Tue, Nov 4, 1:27 AM
Unknown Object (File)
Sun, Nov 2, 7:59 PM
Unknown Object (File)
Sat, Nov 1, 4:37 PM
Unknown Object (File)
Sun, Oct 26, 2:28 AM
Unknown Object (File)
Sun, Oct 26, 1:31 AM
Unknown Object (File)
Fri, Oct 24, 10:47 PM
Unknown Object (File)
Tue, Oct 21, 12:34 PM
View All Files
Subscribers
None

Details

Reviewers
adridg
rakuco
mat
Group Reviewers
O5: Ports Framework
portmgr
kde
Commits
rP427106: Update the dependency code in bsd.qt.mk to the one from kde.mk
Summary

The dependency code from kde.mk can add LIB_DEPENDS if the sense-file is a
library. Import this into bsd.qt.mk

This is done to simplify D8540

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner updated this revision to Diff 22402.Nov 21 2016, 11:22 AM
tcberner retitled this revision from to Update the dependency code in bsd.qt.mk to the one from kde.mk.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, rakuco, mat, adridg.
Owners added a reviewer: O5: Ports Framework.Nov 21 2016, 11:22 AM
Herald added a reviewer: portmgr. · View Herald TranscriptNov 21 2016, 11:22 AM
tcberner added a child revision: D8603: Rename Qt ports not following the normal naming scheme..Nov 21 2016, 11:27 AM
rakuco accepted this revision.Nov 21 2016, 11:30 AM
rakuco edited edge metadata.

looks good to me. @mat?

tcberner updated this revision to Diff 22408.Nov 21 2016, 4:51 PM
tcberner edited edge metadata.

Fixup phonon paths.

Owners edited edge metadata.Nov 21 2016, 4:51 PM
Herald edited edge metadata. · View Herald TranscriptNov 21 2016, 4:51 PM
mat edited edge metadata.Nov 21 2016, 6:25 PM

I have not looked at it in details, but it looks like the right thing to do.

Note that LIB_DEPENDS use ldconfig's data (not ldconfig directly), so, if the library is not in LOCALBASE/lib, the full path to it must be set via USE_LDCONFIG's mechanism in the port providing the library.

tcberner added a comment.Nov 21 2016, 9:31 PM

They all should already have USE_LDCONFIG=${PREFIX}/${QT_LIBDIR_REL} in their Makefiles [and so far at least I have had no fallout while testbuilding this diff].

tcberner updated this revision to Diff 22435.Nov 22 2016, 3:23 PM
tcberner edited edge metadata.

Remove the qmake_TYPE=build line that slipped in from qt.mk.

Owners edited edge metadata.Nov 22 2016, 3:23 PM
Herald edited edge metadata. · View Herald TranscriptNov 22 2016, 3:23 PM
tcberner added a comment.Nov 25 2016, 3:37 AM

Exp-Run looked fine.

mat accepted this revision.Nov 25 2016, 7:50 AM
mat edited edge metadata.

Macro lgtm:

This revision is now accepted and ready to land.Nov 25 2016, 7:50 AM
Closed by commit rP427106: Update the dependency code in bsd.qt.mk to the one from kde.mk (authored by tcberner). · Explain WhyNov 25 2016, 11:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
146 linesO5: Ports Framework

Diff 22505

View Options

head/Mk/bsd.qt.mk

Loading...