Page MenuHomeFreeBSD

Update the dependency code in bsd.qt.mk to the one from kde.mk
ClosedPublic

Authored by tcberner on Nov 21 2016, 11:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 11:46 PM
Unknown Object (File)
Sun, Mar 24, 11:46 PM
Unknown Object (File)
Sun, Mar 24, 11:46 PM
Unknown Object (File)
Tue, Mar 19, 9:55 PM
Unknown Object (File)
Tue, Mar 19, 7:57 PM
Unknown Object (File)
Tue, Mar 12, 3:27 AM
Unknown Object (File)
Thu, Mar 7, 5:37 AM
Unknown Object (File)
Feb 1 2024, 8:37 PM
Subscribers
None

Details

Summary

The dependency code from kde.mk can add LIB_DEPENDS if the sense-file is a
library. Import this into bsd.qt.mk

This is done to simplify D8540

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6036
Build 6302: arc lint + arc unit

Event Timeline

tcberner retitled this revision from to Update the dependency code in bsd.qt.mk to the one from kde.mk.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, rakuco, mat, adridg.
rakuco edited edge metadata.

looks good to me. @mat?

tcberner edited edge metadata.

Fixup phonon paths.

I have not looked at it in details, but it looks like the right thing to do.

Note that LIB_DEPENDS use ldconfig's data (not ldconfig directly), so, if the library is not in LOCALBASE/lib, the full path to it must be set via USE_LDCONFIG's mechanism in the port providing the library.

They all should already have USE_LDCONFIG=${PREFIX}/${QT_LIBDIR_REL} in their Makefiles [and so far at least I have had no fallout while testbuilding this diff].

tcberner edited edge metadata.

Remove the qmake_TYPE=build line that slipped in from qt.mk.

mat edited edge metadata.

Macro lgtm:

This revision is now accepted and ready to land.Nov 25 2016, 7:50 AM
This revision was automatically updated to reflect the committed changes.