nvmft: Return NVME_SC_INVALID_LOG_PAGE for unsupported or invalid log pages
Needs ReviewPublic
Actions

Authored by jhb on Thu, Oct 8, 3:54 PM.

Details

Reviewers

None

Group Reviewers

Summary

The NVMe 1.4 spec is a bit confusing as some (apparently older) text in
section 5.14 says that if a command "specifies a Log Identifier that is
not supported, then the controller should abort the command with
status Invalid Field in Command." However, later in section 5.14.2 that
describes the response to a Get Log Page command there is a table of
command-specific status values with a single entry for "Invalid Log Page"
with the description:

The log page indicated is invalid or not supported. This error condition
is also returned if a reserved log page is requested. Controllers
compliant with versions 1.3 and earlier of the specification may return
Invalid Field in Command for this condition.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77864
Build 74747: arc lint + arc unit

Event Timeline

jhb created this revision.Thu, Oct 8, 3:54 PM

Herald added a reviewer: cam. · View Herald TranscriptThu, Oct 8, 3:54 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Thu, Oct 8, 3:54 PM

Harbormaster completed remote builds in B77864: Diff 189071.Thu, Oct 8, 3:54 PM

jhb added a parent revision: D60479: nvmft: Add various tests for fetching log pages.Thu, Oct 8, 3:54 PM

The 2.0c spec is more consistent with this approach in that the older text is now updated to also mention this error code, though the description of the error code in 2.0c now says that "controllers from 2.0 and before" may return the generic error instead. Note that at present the nvmft module only claims to implement version 1.4.

jhb added a child revision: D60534: nvmft: Add a test for CONNECT with an invalid record format.Fri, Oct 9, 4:05 PM