Fn airplane-mode and rfkill hotkeys for bhotkeys.
airplane-radiosd holds the radios for the session.
Details
Details
- Reviewers
jrm fuz adrian emaste - Commits
- R11:294ed5056de0: x11/bhotkeys-airplane: New port
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 77834 Build 74717: arc lint + arc unit
Event Timeline
Comment Actions
I took a peek at the upstread code and noticed that the RC script does pw groupadd "$airplane_radiosd_group". It would be better if the port did this. See https://docs.freebsd.org/en/books/porters-handbook/book/#users-and-groups.
Comment Actions
Create group (airplane_radiosd:403) as part of package install
Update port to upstream 1.2 which drops group creation
and also fixes service typo in airplane-radiosd(8)
Comment Actions
One thing I missed last time: You also want USE_RC_SUBR as you did in x11/framework-autorotate.
Ref: https://docs.freebsd.org/en/books/porters-handbook/book/#rc-scripts.
Comment Actions
That's only for when the software doesn't ship its own rc.d script. bhotkeys-airplane has its own and also respects DESTDIR and PREFIX, so USE_RC_SUBR is not applicable. Porter's handbook on USE_RC_SUBR:
Scripts must be placed in the files subdirectory and a .in suffix must be added to their filename.
In the case of x11/framework-autorotate there is a files/framework_autorotate.in file to satisfy USE_RC_SUBR. However, in the case of this port, adding it causes a build error on missing file