Differential D60388

epair: Make vnet_epair_uninit() run earlier
ClosedPublic
Actions

Authored by markj on Mon, Oct 5, 10:14 PM.

Details

Reviewers

glebius

Group Reviewers

network

Commits

rG5c20c75b67e3: epair: Make vnet_epair_uninit() run earlier

Summary

I can't see a reason for vnet_epair_init() and vnet_epair_uninit() to be
inconsistent in the sys(un)init run order. Move vnet_epair_uninit() to
SI_SUB_PSEUDO, which is more appropriate for software ifnet drivers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77744
Build 74627: arc lint + arc unit

Event Timeline

markj created this revision.Mon, Oct 5, 10:14 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptMon, Oct 5, 10:14 PM

markj requested review of this revision.Mon, Oct 5, 10:14 PM

Harbormaster completed remote builds in B77744: Diff 188762.Mon, Oct 5, 10:14 PM

markj added a child revision: D60389: linux: Initialize per-VNET state earlier.Mon, Oct 5, 10:14 PM

Different cloner drivers are quite inconsistent with each other about which sysinit subsystem they belong to. Some further cleanup here would be great, here I am just trying to minimally fix a panic I see when running the test suite with the linuxulator loaded.

I tried that once, there was a problem with it, but I don't remember anymore...
But that was about 5 months ago, it might be ok now.

The change is correct, but as Pouria noted all the stuff around here is fragile. There could be bugs fixing other bugs :) Let's proceed with this change and see if there is any fallout that needs to be dealt with.

This revision is now accepted and ready to land.Tue, Oct 6, 4:40 PM

Closed by commit rG5c20c75b67e3: epair: Make vnet_epair_uninit() run earlier (authored by markj). · Explain WhyWed, Oct 7, 1:29 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG5c20c75b67e3: epair: Make vnet_epair_uninit() run earlier.